pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Julien Rouhaud <julien.rouhaud@dalibo.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: segfault in HEAD when too many nested functions call
Date: Wed, 26 Jul 2017 15:03:37 -0400
Message-ID: <20855.1501095817@sss.pgh.pa.us> (raw)
In-Reply-To: <20170726012641.bmhfcp5ajpudihl6@alap3.anarazel.de>
References: <b0af9eaa-130c-60d0-9e4e-7a135b1e0c76@dalibo.com>
	<12302.1500132157@sss.pgh.pa.us>
	<20170717072629.dqykbsot2irdob7c@alap3.anarazel.de>
	<20170717145710.cm32m4yn555hsoxd@alap3.anarazel.de>
	<6687.1500411223@sss.pgh.pa.us>
	<20170721114023.fj6cvr6og46yogei@alap3.anarazel.de>
	<19899.1500682674@sss.pgh.pa.us>
	<20170724161954.gbqswhukk7c4lygt@alap3.anarazel.de>
	<32759.1500917278@sss.pgh.pa.us>
	<20170726012641.bmhfcp5ajpudihl6@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@anarazel.de> writes:
> I've moved the CHECK_FOR_INTERRUPTS() to the callsites. That
> unsurprisingly ends up being somewhat verbose, and there's a bunch of
> minor judgement calls where exactly to place them. While doing so I've
> also added a few extra ones.  Did this in a separate patch to make it
> easier to review.

Hm, that seems kinda backwards to me; I was envisioning the checks
moving to the callees not the callers.  I think it'd end up being
about the same number of occurrences of CHECK_FOR_INTERRUPTS(),
and there would be less of a judgment call about where to put them.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (42+ messages)  latest in thread

Message-ID: <20855.1501095817@sss.pgh.pa.us>
Permalink:  ../20855.1501095817@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20855.1501095817@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, julien.rouhaud@dalibo.com
  Subject: Re: segfault in HEAD when too many nested functions call
  In-Reply-To: <20855.1501095817@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox