public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: Tim McNamara <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: New developer papercut - Makefile references INSTALL
Date: Tue, 18 Jan 2022 16:51:09 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CABUevEw4qN0jQyWyo7w4YkJRV=F15VSE_tLTL-UcPkYAAFEZVg@mail.gmail.com>
	<[email protected]>

> On 17 Jan 2022, at 13:26, Daniel Gustafsson <[email protected]> wrote:
> 
>> On 17 Jan 2022, at 11:25, Magnus Hagander <[email protected]> wrote:
> 
>> That said, I'm not sure we're actually gaining anything by *not*
>> referring to the website as well. TBH, I bet the majority of users
>> will actually prefer to read them there. So I'd suggest always
>> including the reference to the website as well, per the suggestion
>> from Tim.
> 
> Fair point, I'll go ahead and do that in a bit unless anyone objects.

I plan on applying the attached which address the feedback given.

--
Daniel Gustafsson		https://vmware.com/



Attachments:

  [application/octet-stream] install_v2.diff (781B, ../[email protected]/2-install_v2.diff)
  download | inline diff:
diff --git a/Makefile b/Makefile
index 99dcfff654..97b9f2bcbc 100644
--- a/Makefile
+++ b/Makefile
@@ -17,8 +17,14 @@ all:
 
 all check install installdirs installcheck installcheck-parallel uninstall clean distclean maintainer-clean dist distcheck world check-world install-world installcheck-world:
 	@if [ ! -f GNUmakefile ] ; then \
+	   if [ -f INSTALL ] ; then \
+	       INSTRUCTIONS="'INSTALL'"; \
+	   else \
+		   INSTRUCTIONS="'README.git'"; \
+	   fi; \
 	   echo "You need to run the 'configure' program first. See the file"; \
-	   echo "'INSTALL' for installation instructions." ; \
+	   echo "$$INSTRUCTIONS for installation instructions, or visit: " ; \
+	   echo "<https://www.postgresql.org/docs/devel/installation.html>" ; \
 	   false ; \
 	 fi
 	@IFS=':' ; \

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: New developer papercut - Makefile references INSTALL
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox