From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: allow_system_table_mods stuff
Date: Thu, 28 Nov 2019 11:11:44 -0500
Message-ID: <2131.1574957504@sss.pgh.pa.us> (raw)
In-Reply-To: <f48637b7-ab24-e48b-0b30-519b1170e65c@2ndquadrant.com>
References: <a7455db0-2fc0-4ddc-4d8f-e4c860957a34@2ndquadrant.com>
<20190913213940.GA20917@alvherre.pgsql>
<20191127082619.GB237562@paquier.xyz>
<f48637b7-ab24-e48b-0b30-519b1170e65c@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-11-27 09:26, Michael Paquier wrote:
>> Peter, are you planning to look at that again? Note: the patch has no
>> reviewers registered.
> Here is an updated patch series.
> After re-reading the discussion again, I have kept the existing name of
> the option. I have also moved the tests to the "unsafe_tests" suite,
> which seems like a better place. And I have split the patch into three.
Personally I'd have gone with the renaming to allow_system_table_ddl,
but it's not a huge point. Updating the code to agree with that
naming would make the patch much more invasive, so maybe it's not
worth it.
> Other than those cosmetic changes, I think everything here has been
> discussed and agreed to, so unless anyone expresses any concern or a
> wish to do more review, I think this is ready to commit.
I read through the patch set and have just one quibble: in the
proposed new docs,
+ Allows modification of the structure of system tables as well as
+ certain other risky actions on system tables. This is otherwise not
+ allowed even for superusers. This is used by
+ <command>initdb</command>. Inconsiderate use of this setting can
+ cause irretrievable data loss or seriously corrupt the database
+ system. Only superusers can change this setting.
"Inconsiderate" doesn't seem like le mot juste. Maybe "Ill-advised"?
(I'm also wondering whether the sentence about initdb is worth keeping.)
I marked the CF entry RFC.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, alvherre@2ndquadrant.com
Subject: Re: allow_system_table_mods stuff
In-Reply-To: <2131.1574957504@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox