pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: allow_system_table_mods stuff
Date: Fri, 29 Nov 2019 10:30:53 +0100
Message-ID: <440e42c8-948d-d489-cf2f-1f266e087942@2ndquadrant.com> (raw)
In-Reply-To: <2131.1574957504@sss.pgh.pa.us>
References: <a7455db0-2fc0-4ddc-4d8f-e4c860957a34@2ndquadrant.com>
	<20190913213940.GA20917@alvherre.pgsql>
	<20191127082619.GB237562@paquier.xyz>
	<f48637b7-ab24-e48b-0b30-519b1170e65c@2ndquadrant.com>
	<2131.1574957504@sss.pgh.pa.us>

On 2019-11-28 17:11, Tom Lane wrote:
> I read through the patch set and have just one quibble: in the
> proposed new docs,
> 
> +        Allows modification of the structure of system tables as well as
> +        certain other risky actions on system tables.  This is otherwise not
> +        allowed even for superusers.  This is used by
> +        <command>initdb</command>.  Inconsiderate use of this setting can
> +        cause irretrievable data loss or seriously corrupt the database
> +        system.  Only superusers can change this setting.
> 
> "Inconsiderate" doesn't seem like le mot juste.  Maybe "Ill-advised"?
> 
> (I'm also wondering whether the sentence about initdb is worth keeping.)

committed with those adjustments

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (25+ messages)

Message-ID: <440e42c8-948d-d489-cf2f-1f266e087942@2ndquadrant.com>
Permalink:  ../440e42c8-948d-d489-cf2f-1f266e087942@2ndquadrant.com/
Also on:    postgresql.org/message-id/440e42c8-948d-d489-cf2f-1f266e087942@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, alvherre@2ndquadrant.com
  Subject: Re: allow_system_table_mods stuff
  In-Reply-To: <440e42c8-948d-d489-cf2f-1f266e087942@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox