From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org, Noah Misch <noah@leadboat.com>
Cc: exclusion@gmail.com
Subject: Re: Conflict between regression tests namespace & transactions due to recent changes
Date: Mon, 15 May 2023 12:16:08 -0400
Message-ID: <2165312.1684167368@sss.pgh.pa.us> (raw)
In-Reply-To: <80d0201636665d82185942e7112257b4@postgrespro.ru>
References: <80d0201636665d82185942e7112257b4@postgrespro.ru>
Marina Polyakova <m.polyakova@postgrespro.ru> writes:
> IIUC the conflict was caused by
> +SET search_path to public, test_ns_schema_1;
> +CREATE SCHEMA test_ns_schema_2
> + CREATE VIEW abc_view AS SELECT a FROM abc;
> because the parallel regression test transactions had already created
> the table abc and was trying to drop it.
Hmm. I'd actually fix the blame on transactions.sql here. Creating
a table named as generically as "abc" is horribly bad practice in
a set of concurrent tests. namespace.sql is arguably okay, since
it's creating that table name in a private schema.
I'd be inclined to fix this by doing s/abc/something-else/g in
transactions.sql.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, m.polyakova@postgrespro.ru, noah@leadboat.com, exclusion@gmail.com
Subject: Re: Conflict between regression tests namespace & transactions due to recent changes
In-Reply-To: <2165312.1684167368@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox