pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: windows cfbot failing: my_perl
Date: Fri, 26 Aug 2022 23:02:06 -0400
Message-ID: <2167247.1661569326@sss.pgh.pa.us> (raw)
In-Reply-To: <CAFBsxsGYrjEyt+taR1et9bpK6PJeVMAm2dwNR52Gpd84aZ2rHA@mail.gmail.com>
References: <20220826115546.GE2342@telsasoft.com>
	<20220826132151.sj6pieswskq4vp4z@awork3.anarazel.de>
	<20220826134047.vr3bppkwqhy5ppn3@awork3.anarazel.de>
	<20220826142700.fecymkdgdelktrlp@awork3.anarazel.de>
	<CAFBsxsFew_-eaa6geJsR5WcRLeQ9afrPg4rZL59g=3GGu5g_+Q@mail.gmail.com>
	<20220826144740.ff3berqoeoi6lnd4@awork3.anarazel.de>
	<213a7840-f3eb-e294-7d9a-9602d833dad7@dunslane.net>
	<20220826211507.vaepb2nzlh3krxdg@awork3.anarazel.de>
	<CAFBsxsGYrjEyt+taR1et9bpK6PJeVMAm2dwNR52Gpd84aZ2rHA@mail.gmail.com>

John Naylor <john.naylor@enterprisedb.com> writes:
> On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <andres@anarazel.de> wrote:
>> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
>> include in plperl.h would keep that aspect transparent, because plperl_utils.h
>> includes plperl.h.

> Since plperl_helpers.h already includes plperl.h, I'm not sure why
> both are included everywhere the former is. If .c/.xs files didn't
> include plperl.h directly, we could keep pg_wchar.h in
> plperl_helpers.h. Not sure if that's workable or any better...

Maybe we should flush the separate plperl_helpers.h header and just
put those static-inline functions in plperl.h.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <2167247.1661569326@sss.pgh.pa.us>
Permalink:  ../2167247.1661569326@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2167247.1661569326@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, john.naylor@enterprisedb.com, andres@anarazel.de, andrew@dunslane.net, pryzby@telsasoft.com, thomas.munro@gmail.com
  Subject: Re: windows cfbot failing: my_perl
  In-Reply-To: <2167247.1661569326@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox