From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org
Cc: samay sharma <smilingsamay@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: [RFC] building postgres with meson - v12
Date: Wed, 31 Aug 2022 10:28:05 +0200
Message-ID: <2180a97c-c026-1b6c-cec8-d6e499f97017@enterprisedb.com> (raw)
In-Reply-To: <20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
<20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
I found that the perl test modules are not installed. See attached
patch to correct this.
To the patches:
4e15ee0e24 Don't hardcode tmp_check/ as test directory for tap tests
1a3169bc3f Split TESTDIR into TESTLOGDIR and TESTDATADIR
It's a bit weird that the first patch changes the meaning of TESTDIR
and the second patch removes it. Maybe these patches should be
squashed together?
96d1d0a0cf meson: prereq: Extend gendef.pl in preparation for meson
ok
581721fa99 meson: prereq: Add src/tools/gen_export.pl
Still wondering about the whitespace changes I reported recently, but
that can also be fine-tuned later.
4245cc888e meson: prereq: Refactor PG_TEST_EXTRA logic in autoconf build
ok
3afe803e0f meson: prereq: Fix warning compat_informix/rnull.pgc with msvc
ok
ae7733f46c meson: prereq: Move darwin sysroot determination into
separate file
ok
a1fb97a81b meson: Add meson based buildsystem
I'm not a fan of all this business to protect the two build systems
from each other. I don't like the build process touching a file under
version control every time. How necessary is this? What happens
otherwise?
conversion_helpers.txt: should probably be removed now.
doc/src/sgml/resolv.xsl: I don't understand what this is doing. Maybe
at least add a comment in the file.
src/common/unicode/meson.build: The comment at the top of the file
should be moved next to the files it is describing (similar to how it
is in the makefile). I don't see CLDR_VERSION set anywhere. Is that
part implemented?
src/port/win32ver.rc.in: This is redundant with src/port/win32ver.rc.
(Note that the latter is also used as an input file for text
substitution. So having another file named *.in next to it would be
super confusing.)
src/tools/find_meson: Could use a brief comment what it does.
src/tools/pgflex: Could use a not-brief comment about what it does,
why it's needed. Also a comment where it's used. Also run this
through pycodestyle.
src/tools/rcgen: This is connected with the comment on win32ver.rc.in
above. We already have this equivalent code in
src/makefiles/Makefile.win32. Let's figure out a way to share this
code. (It could be a Perl script, which is already required on
Windows.) Also pycodestyle.
src/tools/testwrap: also documentation/comments/pycodestyle
cd193eb3e8 meson: ci: Build both with meson and as before
I haven't reviewed this one in detail. Maybe add a summary in the
commit message, like these are the new jobs, these are the changes to
existing jobs. It looks like there is more in there than just adding
a few meson jobs.
If the above are addressed, I think this will be just about at the
point where the above patches can be committed.
Everything past these patches I'm mentally postponing right now.
Attachments:0001-meson-Install-test-perl-modules.patch (text/plain, 1.1K) download
From 80d6f4f9a574ddb6250e06490c610969aacdb824 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <peter@eisentraut.org>
Date: Wed, 31 Aug 2022 09:16:04 +0200
Subject: [PATCH] meson: Install test perl modules
---
src/test/meson.build | 2 ++
src/test/perl/meson.build | 12 ++++++++++++
2 files changed, 14 insertions(+)
create mode 100644 src/test/perl/meson.build
diff --git a/src/test/meson.build b/src/test/meson.buildindex b86a0f3889..241d9d48aa 100644--- a/src/test/meson.build+++ b/src/test/meson.build@@ -21,3 +21,5 @@ endif
if icu.found()
subdir('icu')
endif
++subdir('perl')diff --git a/src/test/perl/meson.build b/src/test/perl/meson.buildnew file mode 100644index 0000000000..901bae7a56--- /dev/null+++ b/src/test/perl/meson.build@@ -0,0 +1,12 @@+# could use install_data's preserve_path option in >=0.64.0++install_data(+ 'PostgreSQL/Version.pm',+ install_dir: dir_pgxs / 'src/test/perl/PostgreSQL')++install_data(+ 'PostgreSQL/Test/Utils.pm',+ 'PostgreSQL/Test/SimpleTee.pm',+ 'PostgreSQL/Test/RecursiveCopy.pm',+ 'PostgreSQL/Test/Cluster.pm',+ install_dir: dir_pgxs / 'src/test/perl/PostgreSQL/Test')--
2.37.1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, andres@anarazel.de, smilingsamay@gmail.com, byavuz81@gmail.com
Subject: Re: [RFC] building postgres with meson - v12
In-Reply-To: <2180a97c-c026-1b6c-cec8-d6e499f97017@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox