pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Cc: Noah Misch <noah@leadboat.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: AIX support - alignment issues
Date: Wed, 06 Jul 2022 10:01:00 -0400
Message-ID: <2186603.1657116060@sss.pgh.pa.us> (raw)
In-Reply-To: <7890936c-392b-91be-edac-b6d5a500e4b9@enterprisedb.com>
References: <20220702183354.a6uhja35wta7agew@alap3.anarazel.de>
	<CAH2-WzndKXQQGh-7sCOTKL_87Kt918r0F2ztTAraeBCAC8v3OQ@mail.gmail.com>
	<968410.1656789743@sss.pgh.pa.us>
	<CAH2-WzmnoGPN--Z7MfTqv2TTVLJF0Y0tzZbGUS-NAwJ0wv15hw@mail.gmail.com>
	<977853.1656794075@sss.pgh.pa.us>
	<CA+hUKGLo8XVq4c=QpXFO5i3t3u5q6Fope=QgRtE-S3RncP+aUg@mail.gmail.com>
	<1415825.1656893299@sss.pgh.pa.us>
	<CA+hUKGJg5kg7LSeKZm1cDFQCTLBWUF1wvuM4eebJBq9DwYfZYw@mail.gmail.com>
	<1827177.1656996797@sss.pgh.pa.us>
	<CA+hUKGJzapRb3UwJF-bLsv=-p6WLk4_hs6WxR8y9LFTSdJBOCw@mail.gmail.com>
	<7890936c-392b-91be-edac-b6d5a500e4b9@enterprisedb.com>

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 06.07.22 04:21, Thomas Munro wrote:
>> /*
>> * Do not try to collapse these into one "w+" mode file. Doesn't work on
>> -	 * some platforms (eg, HPUX 10.20).
>> +	 * some platforms.
>> */
>> termin = fopen("/dev/tty", "r");
>> termout = fopen("/dev/tty", "w");

> I don't know how /dev/tty behaves in detail under stdio.  I think 
> removing this part of the comment might leave the impression that 
> attempting to use "w+" will never work, whereas the existing comment 
> appears to indicate that it was only very old platforms that had the 
> issue.  If we don't have an immediate answer to that, I'd leave the 
> comment as is.

Yeah, I was kind of wondering whether we should give w+ a try now.
IIRC, the code was like that at one point, but we had to change it
(ie the comment comes from bitter experience).  On the other hand,
it's probably not worth the trouble and risk to change it again.

			regards, tom lane





view thread (48+ messages)  latest in thread

Message-ID: <2186603.1657116060@sss.pgh.pa.us>
Permalink:  ../2186603.1657116060@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2186603.1657116060@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, thomas.munro@gmail.com, pg@bowt.ie, andres@anarazel.de, noah@leadboat.com, robertmhaas@gmail.com
  Subject: Re: AIX support - alignment issues
  In-Reply-To: <2186603.1657116060@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox