pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: postgres_fdw bug in 9.6
Date: Tue, 29 Aug 2017 17:14:31 -0400
Message-ID: <22168.1504041271@sss.pgh.pa.us> (raw)
In-Reply-To: <c5833381-4b03-80a7-36e0-d8e9070bd84b@lab.ntt.co.jp>
References: <CAMkU=1y2G8VOVBHv3iXU2TMAj7-RyBFFW1uhkr5sm9LQ2=X35g@mail.gmail.com>
	<e18b9bf5-1557-cb9c-001e-0861a1d7dfce@lab.ntt.co.jp>
	<CA+TgmoZny9Bte4_rYi2S+vGh1TV69NreAHzD6v96tUxryyDn2w@mail.gmail.com>
	<CAFjFpRd+g1fw5EVR7e=BcJP8adY7WjDBq=SZgo6GH4qyaPRq1A@mail.gmail.com>
	<CA+TgmoaZDP0ysRqwmP=W4cQr57zN6deNcp0gj_xZw8Czwqf13Q@mail.gmail.com>
	<CAFjFpRfSbaaWyJxaGs5Au1gy3puQ13mTGTGF7Az2FAhi+1QQEQ@mail.gmail.com>
	<0700eb97-d9db-33da-4ba2-e28d2a1631d9@lab.ntt.co.jp>
	<47f35675-e504-033a-5bbe-185b78b47c3b@pgmasters.net>
	<23a0e23e-853f-5937-a5fd-84e6c869be92@lab.ntt.co.jp>
	<79b98e30-4d38-7deb-f1fb-bc0bc589a958@lab.ntt.co.jp>
	<CAMkU=1xc0Ee8rBGf=5H8_+KysUDr6qHwZ_cHiJqo5t0FZWVs-w@mail.gmail.com>
	<6a546fa4-6e86-a5ef-8264-cb44d21ff8b6@lab.ntt.co.jp>
	<CA+Tgmoam_AG1FUSwKRdYao+8L=sGezgHJKyobrK--4WQJQduvg@mail.gmail.com>
	<CA+TgmoYsaVVi0MYrfhCww1=uP4cZtZ+uNwLfimqZN10PxzN3HQ@mail.gmail.com>
	<97fd423c-b9b2-4e14-71b3-f48693bb5c04@lab.ntt.co.jp>
	<c5833381-4b03-80a7-36e0-d8e9070bd84b@lab.ntt.co.jp>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> writes:
> [ epqpath-for-foreignjoin-11.patch ]

I started looking at this.  I've not yet wrapped my head around what
CreateLocalJoinPath() is doing, but I noted that Robert's concerns
about ABI breakage in the back branches would not be very difficult
to satisfy.  What we'd need to do is

(1) In the back-branch patch, add the new fields of JoinPathExtraData
at the end, rather than in their more natural locations.  This should
avoid any ABI break for uses of that struct, since there's no reason
why an FDW would be creating its own variables of that type rather
than just using what the core code passes it.

(2) In the back branches, just leave GetExistingLocalJoinPath in place
rather than deleting it.  Existing FDWs would still be subject to the
bug until they were updated, but given how hard it is to trigger, that
doesn't seem like a huge problem.

A variant of (2) is to install a hack fix in GetExistingLocalJoinPath
rather than leaving it unchanged.  I'm not very excited about that though;
it doesn't seem unlikely that we might introduce new bugs that way, and
it would certainly be a distraction from getting the real fix finished.

We'd definitely need to do things that way in 9.6.  I'm not quite sure
whether it's too late to adopt the clean solution in v10.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (128+ messages)  latest in thread

Message-ID: <22168.1504041271@sss.pgh.pa.us>
Permalink:  ../22168.1504041271@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/22168.1504041271@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, fujita.etsuro@lab.ntt.co.jp, robertmhaas@gmail.com, jeff.janes@gmail.com, david@pgmasters.net, ashutosh.bapat@enterprisedb.com
  Subject: Re: postgres_fdw bug in 9.6
  In-Reply-To: <22168.1504041271@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox