pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: cleaning perl code
Date: Sat, 11 Apr 2020 13:41:56 -0400
Message-ID: <22262.1586626916@sss.pgh.pa.us> (raw)
In-Reply-To: <4FFD55FA-0728-4DC3-AF93-0246FE555C10@enterprisedb.com>
References: <e56f6fb6-38d5-8450-577c-24eb5d63f2e1@2ndQuadrant.com>
	<20200411043014.GA590991@rfd.leadboat.com>
	<0a4406d5-b428-4831-8ed9-c36764360f57@2ndQuadrant.com>
	<97813D8D-F185-4998-8CF8-5678746E7DEE@enterprisedb.com>
	<5b2ae2b0-8b09-d153-275a-24e7b2ac7989@2ndQuadrant.com>
	<4FFD55FA-0728-4DC3-AF93-0246FE555C10@enterprisedb.com>

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> I'm less concerned with which perlcritic features you enable than I am with accidentally submitting perl which looks fine to me but breaks the build.  I mostly use perl from within TAP tests, which I run locally before submission to the project.  Can your changes be integrated into the TAP_TESTS makefile target so that I get local errors about this stuff and can fix it before submitting a regression test to -hackers?

As far as that goes, I think crake is just running

src/tools/perlcheck/pgperlcritic

which you can do for yourself as long as you've got perlcritic
installed.

			regards, tom lane

view thread (34+ messages)  latest in thread

Message-ID: <22262.1586626916@sss.pgh.pa.us>
Permalink:  ../22262.1586626916@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/22262.1586626916@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mark.dilger@enterprisedb.com, andrew.dunstan@2ndquadrant.com, noah@leadboat.com
  Subject: Re: cleaning perl code
  In-Reply-To: <22262.1586626916@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox