From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unused header file inclusion
Date: Wed, 31 Jul 2019 09:42:44 -0400
Message-ID: <22397.1564580564@sss.pgh.pa.us> (raw)
In-Reply-To: <20190731063749.GQ1577@paquier.xyz>
References: <CALDaNm1B9naPDTm3ox1m_yZvOm3KA5S4kZQSWWAeLHAQ=3gV1Q@mail.gmail.com>
<20190731055630.GO1577@paquier.xyz>
<CALDaNm2shkzdA3M=KkrwW9GGYf79ZD9=zfOPHRWs=VXKVEectA@mail.gmail.com>
<CAA4eK1+d0mPe63sUUZq19n8n8LDyMxHwcXOOXY7EFeJvz9Owcg@mail.gmail.com>
<20190731063749.GQ1577@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Jul 31, 2019 at 11:55:37AM +0530, Amit Kapila wrote:
>> If we can come up with some such tool, we might be able to integrate
>> it with Thomas's patch tester [1] wherein it can apply the patch,
>> verify if there are unnecessary includes in the patch and report the
>> same.
> Or even get something into src/tools/? If the produced result is
> clean enough, that could be interesting.
I take it nobody has actually bothered to *look* in src/tools.
src/tools/pginclude/README
Note that our experience with this sort of thing has not been very good.
See particularly 1609797c2.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, amit.kapila16@gmail.com, vignesh21@gmail.com
Subject: Re: Unused header file inclusion
In-Reply-To: <22397.1564580564@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox