pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Timing-sensitive case in src/test/recovery TAP tests
Date: Wed, 09 Aug 2017 09:39:04 -0400
Message-ID: <22438.1502285944@sss.pgh.pa.us> (raw)
In-Reply-To: <CAB7nPqRjH5j9Uk=BmJ9j_8-7sqGNqGTFkQrtQACCuqSR7H23qA@mail.gmail.com>
References: <8962.1498425057@sss.pgh.pa.us>
	<CAMsr+YELP+j4OypCoYtRL_Z-KoYrDc+RdqX56mvTBTPqL_55VA@mail.gmail.com>
	<CAB7nPqSZ=YZJeW7m73m+03faPvwykRaQ13fkTOJaV8sym+us_A@mail.gmail.com>
	<17089.1498442945@sss.pgh.pa.us>
	<CAMsr+YE6JEuUAmT657Zq+ix_+6miY3psB7tDZnw8-43LdsB69A@mail.gmail.com>
	<CAB7nPqSfqN_Y16nLSMRVfDM7OAnWJ7mOCxgQZ_zip95sNjZ_Xw@mail.gmail.com>
	<CAMsr+YEbb5rxgZRfCdUbUJwF7rEmbmSVKTbyqYBj48rOARhO=w@mail.gmail.com>
	<CAB7nPqRapQBG8BSUR=UkShJDXCyPYD+GcBNmgSzu4Lw==UzAeQ@mail.gmail.com>
	<14061.1498502642@sss.pgh.pa.us>
	<CAB7nPqTuFCTyDJCNpYZ-MtHhBasjYOzDYkHcn9S1PQBc5MdHtw@mail.gmail.com>
	<18436.1502228036@sss.pgh.pa.us>
	<CAB7nPqRjH5j9Uk=BmJ9j_8-7sqGNqGTFkQrtQACCuqSR7H23qA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Michael Paquier <michael.paquier@gmail.com> writes:
> On Tue, Aug 8, 2017 at 11:33 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Michael Paquier <michael.paquier@gmail.com> writes:
>>> I got the same thought, wondering as well if get_slot_xmins should be
>>> renamed check_slot_xmins with the is() tests moved inside it as well.
>>> Not sure if that's worth the API ugliness though.

>> Mmm, doesn't seem like that's worth doing, but I'm half tempted to merge
>> wait_slot_xmins into get_slot_xmins so you can't skip it ...

> Let's do that please. Merging both was my first feeling when
> refactoring this test upthread. Should I send a patch?

Sure, have at it.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (16+ messages)  latest in thread

Message-ID: <22438.1502285944@sss.pgh.pa.us>
Permalink:  ../22438.1502285944@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/22438.1502285944@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael.paquier@gmail.com, craig@2ndquadrant.com
  Subject: Re: Timing-sensitive case in src/test/recovery TAP tests
  In-Reply-To: <22438.1502285944@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox