From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Christoph Berg <myon@debian.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Date: Mon, 26 Apr 2021 12:56:13 -0400
Message-ID: <2267128.1619456173@sss.pgh.pa.us> (raw)
In-Reply-To: <20210426163135.GU20766@tamriel.snowman.net>
References: <35457b09-36f8-add3-1d07-6034fa585ca8@oss.nttdata.com>
<20210424152220.GL7629@momjian.us>
<CABUevEx4YQi42MwaMq3Bo09=mBqfjUqtkp5NUZpnQ0HdX+5+Hw@mail.gmail.com>
<20210424170908.GM7629@momjian.us>
<1709439.1619286231@sss.pgh.pa.us>
<e832ac41-00dd-3a05-7f52-4b2ae4613508@enterprisedb.com>
<YIbdhrfemBnwAvl5@msg.df7cb.de>
<20210426162104.GQ7629@momjian.us>
<20210426163135.GU20766@tamriel.snowman.net>
Stephen Frost <sfrost@snowman.net> writes:
> * Bruce Momjian (bruce@momjian.us) wrote:
>> Techically, pg_stat_statements can turn on compute_query_id when it is
>> loaded, even if it is 'off' in postgresql.conf, right? And
>> pg_stat_statements would know if an alternate hash method is being used,
>> right?
> +1 on this approach.
That'd make it impossible to turn off or adjust afterwards, wouldn't it?
I'm afraid the confusion stemming from that would outweigh any simplicity.
I would be in favor of logging a message at startup to the effect of
"this is misconfigured" (as per upthread discussion), although whether
people would see that is uncertain.
In the end, it's not like this is the first time we've ever made an
incompatible change in configuration needs; and it won't be the last
either. I don't buy the argument that pg_stat_statements users can't
cope with adding the additional setting. (Of course, we should be
careful to call it out as an incompatible change in the release notes.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, bruce@momjian.us, myon@debian.org, peter.eisentraut@enterprisedb.com, magnus@hagander.net, masao.fujii@oss.nttdata.com, pgsql-hackers@lists.postgresql.org
Subject: Re: compute_query_id and pg_stat_statements
In-Reply-To: <2267128.1619456173@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox