pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Subject: test/modules/test_oat_hooks vs. debug_discard_caches=1
Date: Fri, 18 Nov 2022 15:55:34 -0500
Message-ID: <2267406.1668804934@sss.pgh.pa.us> (raw)

We realized today [1] that it's been some time since the buildfarm
had any debug_discard_caches (nee CLOBBER_CACHE_ALWAYS) coverage.
Sure enough, as soon as Tomas turned that back on, kaboom [2].
The test_oat_hooks test is failing --- it's not crashing, but
it's emitting more NOTICE lines than the expected output includes,
evidently as a result of the hooks getting invoked extra times
during cache reloads.  I can reproduce that here.

Maybe it was a poor design that these hooks were placed someplace
that's sensitive to that.  I dunno.  The only short-term solution
I can think of is to force debug_discard_caches to 0 within that
test script, which is annoying but feasible (since that module
only exists in v15+).

Thoughts, other proposals?

			regards, tom lane

[1] https://www.postgresql.org/message-id/6b52e783-1b32-e723-4311-0e433a5a5a75%40enterprisedb.com
[2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=avocet&dt=2022-11-18%2016%3A01%3A43





view thread (9+ messages)  latest in thread

Message-ID: <2267406.1668804934@sss.pgh.pa.us>
Permalink:  ../2267406.1668804934@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2267406.1668804934@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, tomas.vondra@enterprisedb.com
  Subject: Re: test/modules/test_oat_hooks vs. debug_discard_caches=1
  In-Reply-To: <2267406.1668804934@sss.pgh.pa.us>
  References: <2267406.1668804934@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox