From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Higuchi, Daisuke <higuchi.daisuke@jp.fujitsu.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.
Date: Fri, 19 May 2017 20:49:00 -0400
Message-ID: <22755.1495241340@sss.pgh.pa.us> (raw)
In-Reply-To: <CAB7nPqTmym5t-X6hvMF_P-KRc=ndXtbQCTiU=NhS_jvL7x1kCA@mail.gmail.com>
References: <1803D792815FC24D871C00D17AE95905B1A34A@g01jpexmbkw24>
<CAB7nPqQafwnsKAZ9sv9D8wE_3HU6gge6L0QuPXp9yK=4-2oC1A@mail.gmail.com>
<1803D792815FC24D871C00D17AE95905B1A4CA@g01jpexmbkw24>
<24403.1495225931@sss.pgh.pa.us>
<CAB7nPqTmym5t-X6hvMF_P-KRc=ndXtbQCTiU=NhS_jvL7x1kCA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Michael Paquier <michael.paquier@gmail.com> writes:
> Do you think that it would be better to list the letter list for each
> keyword in repl_scanner.l or have something more generic? As not that
> many commands are added in the replication protocol, I would think
> that this is more than enough for each command, say:
> [Ss][Ll][Oo][Tt] { return K_SLOT; }
> etc.
Yeah, that's probably good enough. It might be worth the trouble to
make out-of-line definitions, as in cubescan.l's handling of NaN and
Infinity for instance, but that's just cosmetic.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael.paquier@gmail.com, higuchi.daisuke@jp.fujitsu.com
Subject: Re: [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.
In-Reply-To: <22755.1495241340@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox