From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Geier <geidav.pg@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add explicit casts in four places to simplehash.h
Date: Fri, 04 Nov 2022 09:25:42 -0400
Message-ID: <2280953.1667568342@sss.pgh.pa.us> (raw)
In-Reply-To: <0f0d2561-1190-1f45-0c5f-ed42f2c80aaf@gmail.com>
References: <aa5d88a3-71f4-3455-11cf-82de0372c941@gmail.com>
<2063437.1667487018@sss.pgh.pa.us>
<0f0d2561-1190-1f45-0c5f-ed42f2c80aaf@gmail.com>
David Geier <geidav.pg@gmail.com> writes:
> On 11/3/22 15:50, Tom Lane wrote:
>> The bigger picture here is that we do actually endeavor to keep
>> (most of) our headers C++ clean, but our tool cpluspluscheck misses
>> these problems because it doesn't try to use these macros.
>> I wonder whether there is a way to do better.
> What about having a custom header alongside cpluspluscheck which
> references all macros we care about?
Can't see that that would help, because of the hand maintenance
required to make it useful.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, geidav.pg@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Add explicit casts in four places to simplehash.h
In-Reply-To: <2280953.1667568342@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox