From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: consider -Wmissing-variable-declarations
Date: Sat, 03 Aug 2024 16:46:23 -0400
Message-ID: <228700.1722717983@sss.pgh.pa.us> (raw)
In-Reply-To: <d8661429-8dec-4d05-808f-4975491ff46a@eisentraut.org>
References: <e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org>
<69d9824f-00ea-49b6-b68d-96f0806ec454@iki.fi>
<acdbdd0c-c91a-4687-9751-ec2d1c3df064@eisentraut.org>
<5cf9f601-a9e7-48ed-a007-714209e9779f@eisentraut.org>
<20240618150238.hm6tr4prhe7porhq@awork3.anarazel.de>
<f39c1137-1d5e-4aac-99f6-361ff9444f7b@eisentraut.org>
<6070f0ee-176f-4e78-9324-3bbb70a191f9@eisentraut.org>
<d8661429-8dec-4d05-808f-4975491ff46a@eisentraut.org>
Peter Eisentraut <peter@eisentraut.org> writes:
> This has all been committed now.
Various buildfarm animals are complaining about
g++ -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Werror=unguarded-availability-new -Wendif-labels -Wmissing-format-attribute -Wcast-function-type -Wformat-security -Wmissing-variable-declarations -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -Wno-cast-function-type-strict -g -O2 -Wno-deprecated-declarations -fPIC -fvisibility=hidden -shared -o llvmjit.so llvmjit.o llvmjit_error.o llvmjit_inline.o llvmjit_wrap.o llvmjit_deform.o llvmjit_expr.o -L../../../../src/port -L../../../../src/common -L/usr/lib64 -Wl,--as-needed -Wl,-rpath,'/home/centos/17-lancehead/buildroot/HEAD/inst/lib',--enable-new-dtags -fvisibility=hidden -lLLVM-17
g++: error: unrecognized command line option \342\200\230-Wmissing-variable-declarations\342\200\231; did you mean \342\200\230-Wmissing-declarations\342\200\231?
make[2]: *** [../../../../src/Makefile.shlib:261: llvmjit.so] Error 1
It looks like we are passing CFLAGS not CXXFLAGS to this particular
g++ invocation.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, hlinnaka@iki.fi, andres@anarazel.de
Subject: Re: consider -Wmissing-variable-declarations
In-Reply-To: <228700.1722717983@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox