From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: longfin missing gssapi_ext.h
Date: Sun, 16 Apr 2023 21:33:43 -0400
Message-ID: <2313469.1681695223@sss.pgh.pa.us> (raw)
In-Reply-To: <ZDf8k3vaQGnhxOry@tamriel.snowman.net>
References: <4080250.1681141040@sss.pgh.pa.us>
<eeb2be64-dcd7-e46c-04b4-0726eb44f901@postgresql.org>
<ZDYG0GkWQa3uZ8yI@tamriel.snowman.net>
<763952.1681272015@sss.pgh.pa.us>
<ZDbBMr1LVy60mAS+@tamriel.snowman.net>
<bcca89d6-9c87-1a92-60dc-229edc758a79@postgresql.org>
<ZDbEnh7KMx9xBG2a@tamriel.snowman.net>
<1123190.1681314906@sss.pgh.pa.us>
<ZDba4e0JzGG6jq39@tamriel.snowman.net>
<1ed077e4-a831-b0b6-7298-0238cf6b0c08@postgresql.org>
<ZDf8k3vaQGnhxOry@tamriel.snowman.net>
Stephen Frost <sfrost@snowman.net> writes:
> Pushed, thanks again to everyone.
> I'll monitor the buildfarm and assuming there isn't anything unexpected
> then I'll mark the open item as resolved now.
The Debian 7 (Wheezy) members of the buildfarm (lapwing, skate, snapper)
are all getting past the gssapi_ext.h check you added and then failing
like this:
ccache gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -Werror -I../../../src/include -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include/et -c -o be-gssapi-common.o be-gssapi-common.c
be-gssapi-common.c: In function 'pg_store_delegated_credential':
be-gssapi-common.c:110:2: error: unknown type name 'gss_key_value_element_desc'
be-gssapi-common.c:111:2: error: unknown type name 'gss_key_value_set_desc'
be-gssapi-common.c:113:4: error: request for member 'key' in something not a structure or union
be-gssapi-common.c:114:4: error: request for member 'value' in something not a structure or union
be-gssapi-common.c:115:7: error: request for member 'count' in something not a structure or union
be-gssapi-common.c:116:7: error: request for member 'elements' in something not a structure or union
be-gssapi-common.c:119:2: error: implicit declaration of function 'gss_store_cred_into' [-Werror=implicit-function-declaration]
Debian 7 has been EOL five years or so, so I don't mind saying "get a
newer OS or disable gssapi". However, is it worth adding another
configure check to fail a little faster with whatever Kerberos
version this is? Checking that gss_store_cred_into() exists
seems like the most obvious one of these things to test for.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, jkatz@postgresql.org, thomas.munro@gmail.com, amit.kapila16@gmail.com, alvherre@alvh.no-ip.org
Subject: Re: longfin missing gssapi_ext.h
In-Reply-To: <2313469.1681695223@sss.pgh.pa.us>
References: <4080250.1681141040@sss.pgh.pa.us> <eeb2be64-dcd7-e46c-04b4-0726eb44f901@postgresql.org> <ZDYG0GkWQa3uZ8yI@tamriel.snowman.net> <763952.1681272015@sss.pgh.pa.us> <ZDbBMr1LVy60mAS+@tamriel.snowman.net> <bcca89d6-9c87-1a92-60dc-229edc758a79@postgresql.org> <ZDbEnh7KMx9xBG2a@tamriel.snowman.net> <1123190.1681314906@sss.pgh.pa.us> <ZDba4e0JzGG6jq39@tamriel.snowman.net> <1ed077e4-a831-b0b6-7298-0238cf6b0c08@postgresql.org> <ZDf8k3vaQGnhxOry@tamriel.snowman.net> <2313469.1681695223@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox