pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: btree_gin and btree_gist for enums
Date: Mon, 27 Feb 2017 16:41:15 -0500
Message-ID: <23417.1488231675@sss.pgh.pa.us> (raw)
In-Reply-To: <1c283f8e-7f26-d2e9-7860-7c4a38390051@2ndQuadrant.com>
References: <56EA8A71.8060107@dunslane.net>
	<CAE2gYzyB=vyquQ2hEWA9UwNb=zYAKFsNO5vBtbfkV2=PzoPZjg@mail.gmail.com>
	<03f7d748-0f89-e8e1-094d-f04e1026b93d@dunslane.net>
	<27220.1478360811@sss.pgh.pa.us>
	<e60f50c4-899a-d48a-6cb4-4611acf2f73c@dunslane.net>
	<31412.1478366009@sss.pgh.pa.us>
	<60fb708c-8b3c-1337-934e-c1bfe2afc539@dunslane.net>
	<db2b70a4-78d7-294a-a315-8e7f506c5978@2ndQuadrant.com>
	<8258.1487886101@sss.pgh.pa.us>
	<4376a7bf-ab8c-e640-9021-94b148f9d733@2ndQuadrant.com>
	<6704.1487952174@sss.pgh.pa.us>
	<930cb563-6dc6-c4af-3be9-31f06c60361e@2ndQuadrant.com>
	<8a8c60b4-39c0-69a4-824c-e364f5fd97ea@2ndQuadrant.com>
	<fac3c5d1-ad66-3a15-c181-c7aadf1d6ad1@2ndQuadrant.com>
	<12734.1488042261@sss.pgh.pa.us>
	<4e730f28-742b-45e9-d507-4d292fbd7834@2ndQuadrant.com>
	<22791.1488047671@sss.pgh.pa.us>
	<c934ffff-c062-39d8-25a0-7157a3ecff49@2ndQuadrant.com>
	<8a9a7d1a-54e4-4d76-ddd6-f5a8f1829de3@2ndQuadrant.com>
	<19852.1488140777@sss.pgh.pa.us>
	<88f65d25-8c32-1e09-f1ad-7f10e372a803@2ndQuadrant.c! om>
	<1c283f8e-7f26-d2e9-7860-7c4a38390051@2ndQuadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> OK, here's the whole series of patches.

I've not tested it at all, but this looks generally sane in a quick
once-over.

A minor quibble is that in 0003, you weren't terribly consistent about
argument order --- in some places you have the FmgrInfo argument added
before the collation argument, and in some places after.  I'd suggest
trying to make the argument orders consistent with the fmgr.c support
functions.  (I'm generally -1 on blindly adding stuff at the end.)

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (39+ messages)  latest in thread

Message-ID: <23417.1488231675@sss.pgh.pa.us>
Permalink:  ../23417.1488231675@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/23417.1488231675@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com
  Subject: Re: btree_gin and btree_gist for enums
  In-Reply-To: <23417.1488231675@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox