pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Inconsistent error message wording for REINDEX CONCURRENTLY
Date: Thu, 02 May 2019 10:06:42 -0400
Message-ID: <23694.1556806002@sss.pgh.pa.us> (raw)

In view of the REINDEX-on-pg_class kerfuffle that we're currently
sorting through, I was very glad to see that the concurrent reindex
code doesn't even try:

regression=# reindex index concurrently pg_class_oid_index;
psql: ERROR:  concurrent reindex is not supported for catalog relations
regression=# reindex table concurrently pg_class; 
psql: ERROR:  concurrent index creation on system catalog tables is not supported

It'd be nice though if those error messages gave the impression of having
been written on the same planet.

(It might be worth comparing wording of other errors-in-common between
what are evidently two completely different code paths...)

			regards, tom lane





view thread (23+ messages)  latest in thread

Message-ID: <23694.1556806002@sss.pgh.pa.us>
Permalink:  ../23694.1556806002@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/23694.1556806002@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: Inconsistent error message wording for REINDEX CONCURRENTLY
  In-Reply-To: <23694.1556806002@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox