pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Nikolay Shaplov <dhyan@nataraj.su>
To: pgsql-hackers@lists.postgresql.org
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: [PATCH] check for ctags utility in make_ctags
Date: Tue, 01 Jan 2019 19:44:04 +0300
Message-ID: <2372584.plvHIL0NPR@x200m> (raw)
In-Reply-To: <20190101022411.GC3243@paquier.xyz>
References: <2394207.ccz7JgCJsh@x200m>
	<3041301.tun4ao7M3a@x200m>
	<20190101022411.GC3243@paquier.xyz>

В письме от вторник, 1 января 2019 г. 11:24:11 MSK пользователь Michael 
Paquier написал:

> Not sure if that's something worse bothering about, but you could do
> the same in src/tools/make_etags.
Good idea. Done.

(I did not do it in the first place because I do not use etags and can't 
properly check it, but really if some files are created, then everything should 
be working well. This is good enough check :-) )


Attachments:

check-for-ctags-in-make_ctags_v3.diff (text/x-patch, 854B)
 download | inline diff:
diff --git a/.gitignore b/.gitignore
index 794e35b..ca14134 100644
diff --git a/src/tools/make_ctags b/src/tools/make_ctags
index 1609c07..052d1e4 100755
--- a/src/tools/make_ctags
+++ b/src/tools/make_ctags
@@ -2,6 +2,13 @@
 
 # src/tools/make_ctags
 
+if [ ! $(command -v ctags) ]
+then
+  echo "'ctags' utility is not found" 1>&2
+  echo "Please install 'ctags' to run make_ctags" 1>&2
+  exit 1
+fi
+
 trap "rm -f /tmp/$$" 0 1 2 3 15
 rm -f ./tags
 
diff --git a/src/tools/make_etags b/src/tools/make_etags
index 3ce96bc..68738e4 100755
--- a/src/tools/make_etags
+++ b/src/tools/make_etags
@@ -2,6 +2,13 @@
 
 # src/tools/make_etags
 
+if [ ! $(command -v etags) ]
+then
+  echo "'etags' utility is not found" 1>&2
+  echo "Please install 'etags' to run make_etags" 1>&2
+  exit 1
+fi
+
 rm -f ./TAGS
 
 find `pwd`/ -type f -name '*.[chyl]' -print |

view thread (14+ messages)  latest in thread

Message-ID: <2372584.plvHIL0NPR@x200m>
Permalink:  ../2372584.plvHIL0NPR@x200m/
Also on:    postgresql.org/message-id/2372584.plvHIL0NPR@x200m

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org, michael@paquier.xyz
  Subject: Re: [PATCH] check for ctags utility in make_ctags
  In-Reply-To: <2372584.plvHIL0NPR@x200m>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox