pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Weird test mixup
Date: Thu, 14 Mar 2024 18:44:54 -0400
Message-ID: <2390106.1710456294@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGK3sCuXMsOKneXOTTFccqsnh5OFSE87+nL5+FK=_z+ppQ@mail.gmail.com>
References: <10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi>
	<2387221.1710454778@sss.pgh.pa.us>
	<CA+hUKGK3sCuXMsOKneXOTTFccqsnh5OFSE87+nL5+FK=_z+ppQ@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> On Fri, Mar 15, 2024 at 11:19 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Do they?  It'd be fairly easy to explain this if these things were
>> being run in "installcheck" style.  I'm not sure about CI, but from
>> memory, the buildfarm does use installcheck for some things.

> Right, as mentioned here:
> https://www.postgresql.org/message-id/flat/CA%2BhUKGJYhcG_o2nwSK6r01eOZJwNWUJUbX%3D%3DAVnW84f-%2B8ya...
> That's the "running" test, which is like the old installcheck.

Hmm.  Seems like maybe we need to institute a rule that anything
using injection points has to be marked NO_INSTALLCHECK.  That's
kind of a big hammer though.

			regards, tom lane

view thread (52+ messages)  latest in thread

Message-ID: <2390106.1710456294@sss.pgh.pa.us>
Permalink:  ../2390106.1710456294@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2390106.1710456294@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, hlinnaka@iki.fi
  Subject: Re: Weird test mixup
  In-Reply-To: <2390106.1710456294@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox