From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)
Date: Sat, 09 Feb 2019 12:13:01 -0500
Message-ID: <24135.1549732381@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+HiwqE+qiSy1JLS63NhpLPRO4dpO6nfK8ZyjK2V-Pz3FCCnEQ@mail.gmail.com>
References: <5943.1549728638@sss.pgh.pa.us>
<20190209165010.GA4298@alvherre.pgsql>
<CA+HiwqE+qiSy1JLS63NhpLPRO4dpO6nfK8ZyjK2V-Pz3FCCnEQ@mail.gmail.com>
Amit Langote <amitlangote09@gmail.com> writes:
> Reading Tom's reply to my email, I wondered if performDeletion won't
> do more than what the code is already doing (except calling the right
> trigger deletion function which the current code doesn't), because the
> trigger in question is an internal trigger without any dependencies
> (the function it invokes are pinned by the system)?
A big part of the point here is to not have to have such assumptions
wired into the fk-cloning code. But even if that internal dependency is
the only one the trigger is involved in, there are other steps in
deleteOneObject that shouldn't be ignored. For example, somebody
could've attached a comment to it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, amitlangote09@gmail.com, alvherre@2ndquadrant.com, pg@bowt.ie
Subject: Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)
In-Reply-To: <24135.1549732381@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox