From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tang, Haiying <tanghy.fnst@cn.fujitsu.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: Support tab completion for upper character inputs in psql
Date: Mon, 15 Mar 2021 21:20:22 +0100
Message-ID: <24171b05-cf0f-3073-a73a-57b45b794049@enterprisedb.com> (raw)
In-Reply-To: <5f225addccc54478a6436b78423f21be@G08CNEXMBPEKD05.g08.fujitsu.local>
References: <a63cbd45e3884cf9b3961c2a6a95dcb7@G08CNEXMBPEKD05.g08.fujitsu.local>
<457958.1612724100@sss.pgh.pa.us>
<20210208.170212.1547983279045749071.horikyota.ntt@gmail.com>
<696766648c7a4266864f843b0e4140dd@G08CNEXMBPEKD05.g08.fujitsu.local>
<5f225addccc54478a6436b78423f21be@G08CNEXMBPEKD05.g08.fujitsu.local>
On 09.02.21 15:48, Tang, Haiying wrote:
> I'm still confused about the APPROPRIATE behavior of tab completion.
> It seems ALTER table/tablespace <name> SET/RESET is already case-insensitive.
>
> For example
> # alter tablespace dbspace set(e[tab]
> # alter tablespace dbspace set(effective_io_concurrency
>
> # alter tablespace dbspace set(E[tab]
> # alter tablespace dbspace set(EFFECTIVE_IO_CONCURRENCY
This case completes with a hardcoded list, which is done
case-insensitively by default. The cases that complete with a query
result are not case insensitive right now. This affects things like
UPDATE T<tab>
as well. I think your first patch was basically right. But we need to
understand that this affects all completions with query results, not
just the one you wanted to fix. So you should analyze all the callers
and explain why the proposed change is appropriate.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, tanghy.fnst@cn.fujitsu.com, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Support tab completion for upper character inputs in psql
In-Reply-To: <24171b05-cf0f-3073-a73a-57b45b794049@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox