From: Nikolay Shaplov <dhyan@nataraj.su>
To: jian he <jian.universality@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Yura Sokolov <y.sokolov@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Cc: Nikolay Shaplov <dhyan@nataraj.su>
Subject: Re: [PATCH] New [relation] option engine
Date: Sat, 22 Jun 2024 21:21:08 +0300
Message-ID: <24214970.ouqheUzb2q@thinkpad-pgpro> (raw)
In-Reply-To: <2726217.uZKlY2gecq@thinkpad-pgpro>
References: <202312081259.2pwkb25emowf@alvherre.pgsql>
<CACJufxFSkfwQR0tPCgzQQjFw5CNxYsFFi7X_gFuPyRacrqKOPQ@mail.gmail.com>
<2726217.uZKlY2gecq@thinkpad-pgpro>
While fixing the patch according to jian he recommendations, I come to a
conclusion that using void* pointer to a structure is really bad idea. Do not
know why I ever did it that way from start.
So I fixed it.
Changes of this fix can be seen here:
https://gitlab.com/dhyannataraj/postgres/-/commit/be4d9e16
The whole patch is attached to this mail.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
Attachments:
[text/x-patch] v9-0001-New-options-engine.patch (0B, ../24214970.ouqheUzb2q@thinkpad-pgpro/2-v9-0001-New-options-engine.patch)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dhyan@nataraj.su, jian.universality@gmail.com, pgsql-hackers@lists.postgresql.org, smithpb2250@gmail.com, alvherre@alvh.no-ip.org, y.sokolov@postgrespro.ru, michael@paquier.xyz
Subject: Re: [PATCH] New [relation] option engine
In-Reply-To: <24214970.ouqheUzb2q@thinkpad-pgpro>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox