From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: longfin missing gssapi_ext.h
Date: Mon, 17 Apr 2023 10:30:14 -0400
Message-ID: <2422362.1681741814@sss.pgh.pa.us> (raw)
In-Reply-To: <ZD1U8wUL2aBss+52@tamriel.snowman.net>
References: <1123190.1681314906@sss.pgh.pa.us>
<ZDba4e0JzGG6jq39@tamriel.snowman.net>
<1ed077e4-a831-b0b6-7298-0238cf6b0c08@postgresql.org>
<ZDf8k3vaQGnhxOry@tamriel.snowman.net>
<2313469.1681695223@sss.pgh.pa.us>
<ZD1CI5zcGopOnzHD@tamriel.snowman.net>
<2415254.1681738677@sss.pgh.pa.us>
<ZD1O+mrRDm5n/ebf@tamriel.snowman.net>
<2418000.1681740070@sss.pgh.pa.us>
<ZD1RVu/jlLJiq5Nw@tamriel.snowman.net>
<ZD1U8wUL2aBss+52@tamriel.snowman.net>
Stephen Frost <sfrost@snowman.net> writes:
> I'm guessing it's not really an issue but it does make changing
> configure a bit annoying on my Ubuntu 22.04, when I run autoconf2.69, I
> end up with this additional hunk as changed from what our configure
> currently has.
Not surprising. Thanks to autoconf's long release cycles, individual
distros often are carrying local patches that affect its output.
To ensure consistent results across committers, our policy is that you
should use built-from-upstream-source autoconf not a vendor's version.
(In principle that could bite us sometime, but it hasn't yet.)
Also, you should generally run autoheader after autoconf.
Checking things here, I notice that pg_config.h.in hasn't been
updated for the last few gssapi-related commits:
$ git diff
inline patch 1: src/include/pg_config.h.in (+6/-0 lines) download inline-1.patchdiff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.inindex 3665e79..6d572c3 100644
*** a/src/include/pg_config.h.in
--- b/src/include/pg_config.h.in
***************
*** 196,201 ****
--- 196,207 ----
/* Define to 1 if you have the `getpeerucred' function. */
#undef HAVE_GETPEERUCRED
+ /* Define to 1 if you have the <gssapi_ext.h> header file. */+ #undef HAVE_GSSAPI_EXT_H+ + /* Define to 1 if you have the <gssapi/gssapi_ext.h> header file. */+ #undef HAVE_GSSAPI_GSSAPI_EXT_H+
/* Define to 1 if you have the <gssapi/gssapi.h> header file. */
#undef HAVE_GSSAPI_GSSAPI_H
Shall I push that, or do you want to?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, jkatz@postgresql.org, thomas.munro@gmail.com, amit.kapila16@gmail.com, alvherre@alvh.no-ip.org
Subject: Re: longfin missing gssapi_ext.h
In-Reply-To: <2422362.1681741814@sss.pgh.pa.us>
References: <1123190.1681314906@sss.pgh.pa.us> <ZDba4e0JzGG6jq39@tamriel.snowman.net> <1ed077e4-a831-b0b6-7298-0238cf6b0c08@postgresql.org> <ZDf8k3vaQGnhxOry@tamriel.snowman.net> <2313469.1681695223@sss.pgh.pa.us> <ZD1CI5zcGopOnzHD@tamriel.snowman.net> <2415254.1681738677@sss.pgh.pa.us> <ZD1O+mrRDm5n/ebf@tamriel.snowman.net> <2418000.1681740070@sss.pgh.pa.us> <ZD1RVu/jlLJiq5Nw@tamriel.snowman.net> <ZD1U8wUL2aBss+52@tamriel.snowman.net> <2422362.1681741814@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox