From: Antonin Houska <ah@cybertec.at>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Unused parameters & co in code
Date: Thu, 31 Jan 2019 10:15:21 +0100
Message-ID: <24267.1548926121@localhost> (raw)
In-Reply-To: <20190130073317.GP3121@paquier.xyz>
References: <20190130073317.GP3121@paquier.xyz>
Michael Paquier <michael@paquier.xyz> wrote:
> Hi all,
>
> I just got a run with CFLAGS with the following options:
> -Wunused-function -Wunused-variable -Wunused-const-variable
> -Wno-unused-result -Wunused-parameter -Wunused-macros
>
> And while this generates a lot of noise for callbacks and depending on
> the environment used, this is also pointing to things which could be
> simplified:
This reminds me that I reported some unused arguments too:
https://www.postgresql.org/message-id/6702.1473067599@localhost
SnapBuildBuildSnapshot() was fixed in commit 6c2003f8a1b, but the other two
are still there.
--
Antonin Houska
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26, A-2700 Wiener Neustadt
Web: https://www.cybertec-postgresql.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: Unused parameters & co in code
In-Reply-To: <24267.1548926121@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox