From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Maksim Milyutin <milyutinma@gmail.com>
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
Date: Thu, 21 Dec 2017 04:58:06 -0500
Message-ID: <242e9c8d-113e-22e5-05bf-550eb0801f7b@redhat.com> (raw)
In-Reply-To: <20171220212503.aamhlrs425flg47f@alvherre.pgsql>
References: <20171220212503.aamhlrs425flg47f@alvherre.pgsql>
Hi Alvaro,
On 12/20/2017 04:25 PM, Alvaro Herrera wrote:
> I modified the regression test so that a partitioning hierarchy would be
> left behind after the test is run, which is useful to test pg_upgrade
> and pg_dump -- this caught one small bug. That and some reading of the
> diff resulted in v8, attach.
>
> On my system, make check-world passes. However, Thomas Munro's
> automated patch tester seems to have a problem with the pg_upgrade test,
> though I don't know what it is.
>
Passes check-world here too w/ TAP + cassert.
index.c:
+ values[Anum_pg_index_indparentidx - 1 ] =
ObjectIdGetDatum(parentIndexOid);
Extra space.
tab-complete.c:
Contains references to DETACH.
create_index.sgml:
I think the new paragraph should mention the naming convention of the
generated indexes, as they may differ from the index name on the
partition table.
reindex.sgml:
Missing a note about REINDEX not being supported on the partition index.
Best regards,
Jesper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jesper.pedersen@redhat.com, alvherre@alvh.no-ip.org, robertmhaas@gmail.com, david.rowley@2ndquadrant.com, simon@2ndquadrant.com, milyutinma@gmail.com
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
In-Reply-To: <242e9c8d-113e-22e5-05bf-550eb0801f7b@redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox