pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Garbled comment in postgresGetForeignJoinPaths
Date: Wed, 16 Aug 2017 15:44:50 -0400
Message-ID: <24365.1502912690@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmobCHb-y6mjQH+LPnv4cK1Gd8pKj6k8UcNYm9SA1NwTXtQ@mail.gmail.com>
References: <27897.1502901074@sss.pgh.pa.us>
	<CA+TgmoY377WU7N-Z6D5iCRWVJWY9G+RzaomD+eOX28dOLEnyeQ@mail.gmail.com>
	<302.1502907403@sss.pgh.pa.us>
	<CA+Tgmoas+qcw1uo06GNkpXoNKknpfdTShc2x09RrXa8x0MLM0A@mail.gmail.com>
	<CA+TgmobCHb-y6mjQH+LPnv4cK1Gd8pKj6k8UcNYm9SA1NwTXtQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Aug 16, 2017 at 3:02 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Wed, Aug 16, 2017 at 2:16 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> The current text of the comment dates to commit 177c56d60, and looking at
>>> that commit makes it pretty clear that the line I'm complaining of
>>> belonged to the previous text; it evidently just missed getting deleted.

>> Got it.  Nice forensics, and sorry about the good.

> ... goof.

Will you fix it, or shall I?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (9+ messages)  latest in thread

Message-ID: <24365.1502912690@sss.pgh.pa.us>
Permalink:  ../24365.1502912690@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/24365.1502912690@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com
  Subject: Re: Garbled comment in postgresGetForeignJoinPaths
  In-Reply-To: <24365.1502912690@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox