From: Tom Lane <tgl@sss.pgh.pa.us>
To: Euler Taveira <euler@eulerto.com>
Cc: Michael Banck <mbanck@gmx.net>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Tristan Partin <tristan@neon.tech>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add --check option to pgindent
Date: Tue, 12 Dec 2023 10:18:00 -0500
Message-ID: <2437426.1702394280@sss.pgh.pa.us> (raw)
In-Reply-To: <fc31d7f9-c912-4323-b3c0-4aaf6dc967d5@app.fastmail.com>
References: <CXLX2XYTH9S6.140SC6Y61VD88@neon.tech>
<C4149FA1-AB7F-4869-8A5B-A029A70212CB@yesql.se>
<657835bb.500a0220.a88d.2058@mx.google.com>
<fc31d7f9-c912-4323-b3c0-4aaf6dc967d5@app.fastmail.com>
"Euler Taveira" <euler@eulerto.com> writes:
> When you add exceptions, it starts to complicate the UI.
Indeed. It seems like --silent-diff was poorly defined and poorly
named, and we need to rethink that option along the way to adding
this behavior. The idea that --show-diff and --silent-diff can
be used together is just inherently confusing, because they sound
like opposites.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, euler@eulerto.com, mbanck@gmx.net, daniel@yesql.se, tristan@neon.tech
Subject: Re: Add --check option to pgindent
In-Reply-To: <2437426.1702394280@sss.pgh.pa.us>
References: <CXLX2XYTH9S6.140SC6Y61VD88@neon.tech> <C4149FA1-AB7F-4869-8A5B-A029A70212CB@yesql.se> <657835bb.500a0220.a88d.2058@mx.google.com> <fc31d7f9-c912-4323-b3c0-4aaf6dc967d5@app.fastmail.com> <2437426.1702394280@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox