From: Tom Lane <tgl@sss.pgh.pa.us>
To: Maksim Milyutin <milyutinma@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] wrong t_bits alignment in pageinspect
Date: Thu, 04 Jan 2018 15:03:06 -0500
Message-ID: <24561.1515096186@sss.pgh.pa.us> (raw)
In-Reply-To: <da8b621a-ebbd-4fe6-c436-130cc8beb0a0@gmail.com>
References: <ec295792-a69f-350f-6287-25a20e8f31d5@gmail.com>
<9B8647CA-7097-4A8C-9721-6DFAEE93D6AA@yandex-team.ru>
<da8b621a-ebbd-4fe6-c436-130cc8beb0a0@gmail.com>
Maksim Milyutin <milyutinma@gmail.com> writes:
> Attached a new version of patch with regression test.
Looks good, pushed.
I also removed one error check from tuple_data_split --- there doesn't
seem to be a lot of point in checking that bits_str_len is some multiple
of 8 when we're about to check that it's equal to a particular multiple
of 8.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, milyutinma@gmail.com, x4mmm@yandex-team.ru
Subject: Re: [HACKERS] wrong t_bits alignment in pageinspect
In-Reply-To: <24561.1515096186@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox