From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Jesper Pedersen <jesper.pedersen@redhat.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Oskari Saarenmaa <os@ohmu.fi>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Tobias Oberstein <tobias.oberstein@gmail.com>
Subject: Re: pread() and pwrite()
Date: Tue, 06 Nov 2018 10:32:02 -0500
Message-ID: <24643.1541518322@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEepm=1GmuQ---ZDmmDzU6uS0QF==PeD1N-XLY7pSfndxTpnfQ@mail.gmail.com>
References: <20181105155918.jg36uj4rtnxwqtzt@alvherre.pgsql>
<1791.1541438632@sss.pgh.pa.us>
<CAEepm=1GmuQ---ZDmmDzU6uS0QF==PeD1N-XLY7pSfndxTpnfQ@mail.gmail.com>
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Tue, Nov 6, 2018 at 6:23 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> What I suggest is that we *not* try to make this a completely transparent
>> substitute. Instead, make the functions exported by src/port/ be
>> "pg_pread" and "pg_pwrite", ...
> OK. But since we're using this from both fd.c and xlog.c, I put that
> into src/include/port.h.
LGTM. I didn't bother to run an actual test cycle, since it's not
materially different from the previous version as far as portability
is concerned.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, alvherre@2ndquadrant.com, jesper.pedersen@redhat.com, magnus@hagander.net, os@ohmu.fi, tobias.oberstein@gmail.com
Subject: Re: pread() and pwrite()
In-Reply-To: <24643.1541518322@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox