pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Compiler warnings
Date: Mon, 02 Jan 2017 14:58:34 -0500
Message-ID: <2475.1483387114@sss.pgh.pa.us> (raw)
In-Reply-To: <8bdec5ad-808b-fbb3-a33f-b88cbe19cf3b@joeconway.com>
References: <20161129152102.GR13284@tamriel.snowman.net>
	<20161206202305.GQ23417@tamriel.snowman.net>
	<CA+Tgmoa5UOy=U_jWVyyJcpR4gqWREcq6KUD+afRbrakqyhe9aQ@mail.gmail.com>
	<20161206204644.GS23417@tamriel.snowman.net>
	<CA+TgmoYyf=09KaF2x8F43F-tSYdKvBud53VGGDVZKGdcdOS+=g@mail.gmail.com>
	<e7b6eff6-a9de-fe8b-00ef-6fde5d5d8cf0@joeconway.com>
	<CA+TgmoYeuEny2R0iUyy8zy9909VkcUQxrj6+nKzodJpUeUx-0A@mail.gmail.com>
	<21d0ae19-c280-086f-2109-4b1174c74af6@joeconway.com>
	<677.1483384145@sss.pgh.pa.us>
	<8bdec5ad-808b-fbb3-a33f-b88cbe19cf3b@joeconway.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Joe Conway <mail@joeconway.com> writes:
> On 01/02/2017 11:09 AM, Tom Lane wrote:
>> The bison issue is discussed in
>> https://www.postgresql.org/message-id/flat/E1WpjkB-0003zA-N4%40gemulon.postgresql.org

> Ah, thanks. I vaguely remember that thread now.

> Looks like there was some consensus for applying Peter's patch with the
> addition of a comment, but apparently that never happened. Would we
> still consider that for 9.2 and 9.3 branches?

Sure it did, see 55fb759ab3e7543a6be72a35e6b6961455c5b393.
That's why you don't see the complaints in 9.4 and up.
I'm not sure why Peter didn't back-patch it, but doing so now seems
safe enough.

> Any thoughts on fixing the other warnings?

I'm okay with small, low-risk patches to silence warnings in back
branches.  Like Robert, I'd be concerned about anything invasive.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (17+ messages)  latest in thread

Message-ID: <2475.1483387114@sss.pgh.pa.us>
Permalink:  ../2475.1483387114@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2475.1483387114@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mail@joeconway.com, robertmhaas@gmail.com, sfrost@snowman.net
  Subject: Re: Compiler warnings
  In-Reply-To: <2475.1483387114@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox