From: Joe Conway <mail@joeconway.com>
To: Robert Haas <robertmhaas@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Compiler warnings
Date: Thu, 29 Dec 2016 07:47:28 -0800
Message-ID: <e7b6eff6-a9de-fe8b-00ef-6fde5d5d8cf0@joeconway.com> (raw)
In-Reply-To: <CA+TgmoYyf=09KaF2x8F43F-tSYdKvBud53VGGDVZKGdcdOS+=g@mail.gmail.com>
References: <20161129152102.GR13284@tamriel.snowman.net>
<20161206202305.GQ23417@tamriel.snowman.net>
<CA+Tgmoa5UOy=U_jWVyyJcpR4gqWREcq6KUD+afRbrakqyhe9aQ@mail.gmail.com>
<20161206204644.GS23417@tamriel.snowman.net>
<CA+TgmoYyf=09KaF2x8F43F-tSYdKvBud53VGGDVZKGdcdOS+=g@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 12/06/2016 01:59 PM, Robert Haas wrote:
> On Tue, Dec 6, 2016 at 3:46 PM, Stephen Frost <sfrost@snowman.net> wrote:
>> Good thought, thanks!
>>
>> Updated patch attached with that change and I also added an Assert() to
>> GetCachedPlan(), in case that code gets whacked around later and somehow
>> we end up falling through without actually setting *plan.
>>
>> Thoughts?
>
> wfm
>
Shouldn't this be back-patched? The plancache warning goes back through
9.2 (at least) and the lwlocks warning through 9.5 (or maybe it was 9.4).
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: mail@joeconway.com, robertmhaas@gmail.com, sfrost@snowman.net
Subject: Re: Compiler warnings
In-Reply-To: <e7b6eff6-a9de-fe8b-00ef-6fde5d5d8cf0@joeconway.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox