From: Tom Lane <tgl@sss.pgh.pa.us>
To: 蔡梦娟(玊于) <mengjuan.cmj@alibaba-inc.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add guc to enable send SIGSTOP to peers when backend exits abnormally
Date: Fri, 03 Sep 2021 10:39:33 -0400
Message-ID: <2498875.1630679973@sss.pgh.pa.us> (raw)
In-Reply-To: <1a53af38-851a-4ad0-9ff1-54e7b8aeca73.mengjuan.cmj@alibaba-inc.com>
References: <1a53af38-851a-4ad0-9ff1-54e7b8aeca73.mengjuan.cmj@alibaba-inc.com>
"=?UTF-8?B?6JSh5qKm5aifKOeOiuS6jik=?=" <mengjuan.cmj@alibaba-inc.com> writes:
> I want to share a patch with you, in which I add a guc parameter 'enable_send_stop' to enable set the value of SendStop in postmaster.c more conveniently. SendStop enable postmaster to send SIGSTOP rather than SIGQUIT to its children when some backend dumps core, and this variable is originally set with -T parameter when start postgres, which is inconvenient to control in some scenarios.
TBH, I'd sooner rip out SendStop, and simplify the related postmaster
logic. I've never used it in twenty-some years of Postgres hacking,
and I doubt anyone else has used it much either. It's not worth the
overhead of a GUC. (The argument that you need it in situations
where you can't control the postmaster's command line seems pretty
thin, too. I'm much more worried about somebody turning it on by
accident and then complaining that the cluster freezes upon crash.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, mengjuan.cmj@alibaba-inc.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Add guc to enable send SIGSTOP to peers when backend exits abnormally
In-Reply-To: <2498875.1630679973@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox