From: Tom Lane <tgl@sss.pgh.pa.us>
To: Glen Knowles <gknowles@ieee.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: _WINSOCK_DEPRECATED_NO_WARNINGS
Date: Thu, 16 Nov 2017 22:46:55 -0500
Message-ID: <25237.1510890415@sss.pgh.pa.us> (raw)
In-Reply-To: <CAJCH0yD6bP_qGxawjawWNCJdrL1ncg-Yfey7TCYWfsFTYvdBbA@mail.gmail.com>
References: <20124.1510850225@sss.pgh.pa.us>
<CAJCH0yD6bP_qGxawjawWNCJdrL1ncg-Yfey7TCYWfsFTYvdBbA@mail.gmail.com>
Glen Knowles <gknowles@ieee.org> writes:
> On Thu, Nov 16, 2017 at 8:37 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> but evidently it chose the wrong cutoff for when to enable that
>> symbol, because woodlouse is (or claims to be) running VS2013.
> It's actually checking the wrong thing, the problem is the version of the
> Windows SDK, and while the one installed by default with VS2015 might be
> the right place to cutoff it's not uncommon to have multiple versions of
> the SDK (and VS) in various combinations.
Ah, interesting point --- though it's not clear that woodlouse is actually
running a mixture of SDK/VS releases.
> Or you could just define it unconditionally. :)
Already done that way.
I wonder though if this means the other tests of _MSC_VER in our tree
are wrong?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, gknowles@ieee.org
Subject: Re: _WINSOCK_DEPRECATED_NO_WARNINGS
In-Reply-To: <25237.1510890415@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox