From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Subject: Re: Back-branch bugs with fully-prunable UPDATEs
Date: Sun, 07 Apr 2019 12:57:45 -0400
Message-ID: <25275.1554656265@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+HiwqExk2yo57aX2Mj99nR0SOP4s43J1+nccLm6h=3UzoX0qQ@mail.gmail.com>
References: <20710.1554582479@sss.pgh.pa.us>
<CA+HiwqExk2yo57aX2Mj99nR0SOP4s43J1+nccLm6h=3UzoX0qQ@mail.gmail.com>
Amit Langote <amitlangote09@gmail.com> writes:
> On Sun, Apr 7, 2019 at 5:28 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This test script works fine in HEAD:
>> In v11, it suffers an assertion failure in ExecSetupPartitionTupleRouting.
>> In v10, it doesn't crash, but we do get
>> WARNING: relcache reference leak: relation "parttbl" not closed
> What we did in the following commit is behind this:
> commit 58947fbd56d1481a86a03087c81f728fdf0be866
> Before this commit, partitioning related code in the executor could
> always rely on the fact that ModifyTableState.resultRelInfo[] only
> contains *leaf* partitions. As of this commit, it may contain the
> root partitioned table in some cases, which breaks that assumption.
Ah. Thanks for the diagnosis and patches; pushed.
I chose to patch HEAD similarly to v11, even though no bug manifests
right now; it seems safer that way. We should certainly have the
test case in HEAD, now that we realize there wasn't coverage for this.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, amitlangote09@gmail.com, pgsql-hackers@lists.postgresql.org, Langote_Amit_f8@lab.ntt.co.jp
Subject: Re: Back-branch bugs with fully-prunable UPDATEs
In-Reply-To: <25275.1554656265@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox