From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: meson PGXS compatibility
Date: Wed, 05 Oct 2022 16:20:22 -0400
Message-ID: <2551486.1665001222@sss.pgh.pa.us> (raw)
In-Reply-To: <20221005200710.luvw5evhwf6clig6@awork3.anarazel.de>
References: <20221005200710.luvw5evhwf6clig6@awork3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On macOS we ran ranlib after installing a static library. This was added a
> long time ago, in 58ad65ec2def. I cannot reproduce an issue in more recent
> macOS versions.
I agree that shouldn't be necessary anymore (and if it is, we'll find
out soon enough).
> I'm on the fence about removing the "touch $@" from the rule building static
> libs. That was added because of macos's ranlib not setting fine-grained
> timestamps. On a modern mac ar and ranlib are the same binary, and maybe
> that means that ar has the same issue? Both do set fine-grained
> timestamps:
Please see the commit message for 826eff57c4c: the issue seems to arise
only with specific combinations of software, in particular with non-Apple
versions of "make" (although maybe later Apple builds have fixed make's
failure to read sub-second timestamps?). That's a relatively recent hack,
and I'm very hesitant to conclude that we don't need it anymore just
because you failed to reproduce an issue locally. It very possibly isn't
a problem in a meson build, though, depending on how much meson depends on
file timestamps.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, byavuz81@gmail.com, peter.eisentraut@enterprisedb.com
Subject: Re: meson PGXS compatibility
In-Reply-To: <2551486.1665001222@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox