pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
Date: Wed, 01 May 2019 15:08:56 -0400
Message-ID: <5483.1556737736@sss.pgh.pa.us> (raw)
In-Reply-To: <20190501172115.4cvz3rp6np43odut@alap3.anarazel.de>
References: <16277.1556649660@sss.pgh.pa.us>
	<20190430190308.kga2z5oz7vab7w22@alap3.anarazel.de>
	<17996.1556651503@sss.pgh.pa.us>
	<20190430221045.6slpi2vm2noda5jb@alap3.anarazel.de>
	<28313.1556663080@sss.pgh.pa.us>
	<28926.1556664156@sss.pgh.pa.us>
	<20190430225307.lvfvcf2776iywhw4@alap3.anarazel.de>
	<20190501013638.7u7fwr4zktbyyng5@alap3.anarazel.de>
	<25049.1556727622@sss.pgh.pa.us>
	<20190501170603.hx6r3ztyvi3rlgq6@alap3.anarazel.de>
	<20190501172115.4cvz3rp6np43odut@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2019-05-01 10:06:03 -0700, Andres Freund wrote:
>> I'm not sure this is the right short-term answer. Why isn't it, for now,
>> sufficient to do what I suggested with RelationSetNewRelfilenode() not
>> doing the CommandCounterIncrement(), and reindex_index() then doing the
>> SetReindexProcessing() before a CommandCounterIncrement()? That's like
>> ~10 line code change, and a few more with comments.

That looks like a hack to me...

The main thing I'm worried about right now is that I realized that
our recovery from errors in this area is completely hosed, cf
https://www.postgresql.org/message-id/4541.1556736252@sss.pgh.pa.us

The problem with CCA is actually kind of convenient for testing that,
since it means you don't have to inject any new fault to get an error
to be thrown while the index relcache entry is in the needing-to-be-
reverted state.  So I'm going to work on fixing the recovery first.
But I suspect that doing this right will require the more complicated
approach anyway.

			regards, tom lane





view thread (82+ messages)  latest in thread

Message-ID: <5483.1556737736@sss.pgh.pa.us>
Permalink:  ../5483.1556737736@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/5483.1556737736@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
  In-Reply-To: <5483.1556737736@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox