From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <hornschnorter@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes
Date: Fri, 17 Feb 2017 16:31:57 -0500
Message-ID: <25938.1487367117@sss.pgh.pa.us> (raw)
In-Reply-To: <B9FB1155-B39D-43C9-A7E6-B67E1C59E4CE@gmail.com>
References: <20170217181348.a5pnflupslw2t6xx@alvherre.pgsql>
<32279.1487355685@sss.pgh.pa.us>
<2664.1487360457@sss.pgh.pa.us>
<0C821A10-45A2-4112-A1A2-EDAE27712C62@anarazel.de>
<16461.1487361849@sss.pgh.pa.us>
<CAEepm=1wVjmuPCdtgyn7-huNFAabhu4b7VwoRpCcVtQ7C=ScTw@mail.gmail.com>
<19678.1487362865@sss.pgh.pa.us>
<B9FB1155-B39D-43C9-A7E6-B67E1C59E4CE@gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Mark Dilger <hornschnorter@gmail.com> writes:
> if test "$GCC" = yes -a "$ICC" = no; then
> CFLAGS="-Wall -Wmissing-prototypes -Wpointer-arith"
> + PGAC_PROG_CC_CFLAGS_OPT([-Wempty-body])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wignored-qualifiers])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wimplicit-fallthrough])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wtype-limits])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wuninitialized])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wshift-negative-value])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wmissing-include-dirs])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wshift-overflow])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wswitch-default])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wdangling-else])
> + PGAC_PROG_CC_CFLAGS_OPT([-Waggregate-return])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wstrict-prototypes])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wmissing-declarations])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wredundant-decls])
> + PGAC_PROG_CC_CFLAGS_OPT([-Winline])
> + PGAC_PROG_CC_CFLAGS_OPT([-Woverlength-strings])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wc++-compat])
> + PGAC_PROG_CC_CFLAGS_OPT([-Wold-style-definition])
> # These work in some but not all gcc versions
> PGAC_PROG_CC_CFLAGS_OPT([-Wdeclaration-after-statement])
> PGAC_PROG_CC_CFLAGS_OPT([-Wendif-labels])
I'm not terribly for that. For the most part, if a gcc warning isn't
included by '-Wall', there's a reason for it. We could talk about
whether individual extra warnings are useful for the Postgres project,
but I don't want to suddenly move the goalposts to where we are
enforcing a bunch of pedantic warnings that different compiler versions
might not even interpret the same. I'm particularly not for turning
them up in the way you suggest here, where violations would result in
buildfarm failures on machines running with -Werror.
Right now I'd rather focus on getting to where we can have -Werror on in
the buildfarm at all. longfin says we've got work to do on that, at least
in the back branches. It may be that we can't expect near-EOL branches to
always compile perfectly cleanly on newer compilers.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, hornschnorter@gmail.com, thomas.munro@enterprisedb.com, andres@anarazel.de, alvherre@2ndquadrant.com, andrew@dunslane.net
Subject: Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes
In-Reply-To: <25938.1487367117@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox