From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: valgrind issues on Fedora 28
Date: Fri, 14 Dec 2018 22:35:56 +0100
Message-ID: <25de4d8b-2192-20f0-7d30-6c5b79ddf716@2ndquadrant.com> (raw)
In-Reply-To: <11849.1544803095@sss.pgh.pa.us>
References: <20181106173527.omm63tiaguxft7mg@alvherre.pgsql>
<f6577fe9-def2-7614-958f-9a8fb810f666@2ndquadrant.com>
<23c8e539-6777-1793-0939-12e73cb98314@2ndquadrant.com>
<9063c043-83cd-b439-a928-622a743edd2c@2ndquadrant.com>
<16353.1544760625@sss.pgh.pa.us>
<4721dbaf-b922-9e30-e635-00f06512edac@2ndquadrant.com>
<11849.1544803095@sss.pgh.pa.us>
On 12/14/18 4:58 PM, Tom Lane wrote:
> ...
>
> In general, I'm not particularly on board with our valgrind.supp
> carrying suppressions for code outside our own code base: I think
> that's assuming WAY too much about which version of what is installed
> on a particular box.
>
Fair point.
> Maybe we could do something to make it simpler to have custom
> suppressions? Not sure what, though.
>
I was thinking that perhaps we could allows specifying path to extra
suppressions and pass that to valgrind.
But we don't actually invoke valgrind, that's something people do on
their own anyway - so we don't have anywhere to pass the path to. And
whoever invokes valgrind can simply stick it directly into the command
they're using (as it allows specifying multiple --suppressions=<file>
options). Or perhaps just put it into ~/.valgrindrc.
So perhaps we should simply revert that commit and be done with it.
One place that will need to solve it is buildfarm client, but it could
pick either of the options I mentioned.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: valgrind issues on Fedora 28
In-Reply-To: <25de4d8b-2192-20f0-7d30-6c5b79ddf716@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox