From: Nikolay Shaplov <dhyan@nataraj.su>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM
Date: Tue, 28 Nov 2017 09:12:01 +0300
Message-ID: <2621611.3GR6eXjdAP@x200m> (raw)
In-Reply-To: <CAB7nPqS+nkYg4uxyTTeZWZjZVW4rTCMAqzzduQNHmDH2GoQC3Q@mail.gmail.com>
References: <20170903094543.kkqdbdjuxwa5z6ji@alvherre.pgsql>
<CAB7nPqSvJug6XLzHJ898bZSu5DCgYgcWd0iEsdUU3BMXgvwXwg@mail.gmail.com>
<CAB7nPqS+nkYg4uxyTTeZWZjZVW4rTCMAqzzduQNHmDH2GoQC3Q@mail.gmail.com>
В письме от 28 ноября 2017 11:23:38 пользователь Michael Paquier написал:
> On Tue, Nov 28, 2017 at 11:22 AM, Michael Paquier
>
> <michael.paquier@gmail.com> wrote:
> > On Tue, Nov 14, 2017 at 4:44 PM, Michael Paquier
> >
> > <michael.paquier@gmail.com> wrote:
> >> On Mon, Oct 30, 2017 at 9:49 AM, Nikolay Shaplov <dhyan@nataraj.su>
wrote:
> >>> В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera
> >>> написал:
> >>>
> >>> Yet another git rebase. This patch can be applied to master branch
> >>> again.
> >>>
> >>> For this patch no review needed now, as I will offer part of it (one
> >>> that
> >>> refuses to set toast reloptions when there is no TOAST table) as a
> >>> separate
> >>> patch.
> >>
> >> This patch needs a rebase, there are conflicts with HEAD.
> >
> > Bumping the patch to next CF as no updates have happened for the last two
> > weeks.
> Er, returned with feedback.. This will be my last patch for the day.
May be you are right. This patch should be split into smaller patches. I will
do it bit by bit whet I have time. But I see no reason for the big one to
remain on commitfest, as it is not for direct commit.
PS. I will do the rebase soon, this patch overlaps with two recent commits. So
this require very careful rebasing....
--
Do code for fun. Can do it for money (Perl & C/C++ ~10h/week)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dhyan@nataraj.su, michael.paquier@gmail.com, alvherre@alvh.no-ip.org, andres@anarazel.de
Subject: Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM
In-Reply-To: <2621611.3GR6eXjdAP@x200m>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox