From: Tom Lane <tgl@sss.pgh.pa.us>
To: Craig Ringer <craig@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Manuel Kniep <m.kniep@web.de>
Cc: fujita.etsuro@lab.ntt.co.jp <fujita.etsuro@lab.ntt.co.jp>
Subject: Re: PATCH: Batch/pipelining support for libpq
Date: Tue, 24 May 2016 00:28:40 -0400
Message-ID: <2644.1464064120@sss.pgh.pa.us> (raw)
In-Reply-To: <CAMsr+YGY7CO8+vWBqFfdYLqzrZSpcKHc-AVWSu25_++kek-Ecw@mail.gmail.com>
References: <CAMsr+YFUjJytRyV4J-16bEoiZyH=4nj+sQ7JP9ajwz=B4dMMZw@mail.gmail.com>
<20160523155002.debxru4u57tqztyy@alap3.anarazel.de>
<CAB7nPqQgXamo_XEV37ZvfSO3Od-jtgyXdRAGfy251+AFsjNwig@mail.gmail.com>
<CAMsr+YGY7CO8+vWBqFfdYLqzrZSpcKHc-AVWSu25_++kek-Ecw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Craig Ringer <craig@2ndquadrant.com> writes:
> On 24 May 2016 at 00:00, Michael Paquier <michael.paquier@gmail.com> wrote:
>> Did you consider the use of simple_list.c instead of introducing a new
>> mimic as PGcommandQueueEntry? It would be cool avoiding adding new
>> list emulations on frontends.
> I'd have to extend simple_list to add a generic object version, like
> struct my_list_elem
> {
> PG_SIMPLE_LIST_ATTRS;
> mytype mycol;
> myothertype myothercol;
> }
> Objections?
That doesn't look exactly "generic".
> I could add a void* version that's a simple clone of the string version,
> but having to malloc both a list cell and its contents separately is
> annoying.
I'd be okay with a void* version, but I'm not sure about this.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, craig@2ndquadrant.com, michael.paquier@gmail.com, andres@anarazel.de, m.kniep@web.de, fujita.etsuro@lab.ntt.co.jp
Subject: Re: PATCH: Batch/pipelining support for libpq
In-Reply-To: <2644.1464064120@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox