pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ronan Dunklau <ronan.dunklau@aiven.io>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
Date: Mon, 04 Nov 2024 11:10:01 -0500
Message-ID: <2650823.1730736601@sss.pgh.pa.us> (raw)
In-Reply-To: <3316564.aeNJFYEL58@aivenlaptop>
References: <3395418.1618352794@sss.pgh.pa.us>
	<icwj06MeNjimdlNmL6h9X5bmqwe0QngwSOzunFna3RS9fYIxyAFMi7UG7hOp4CQTmFEHDkdhG3z9iBpXHBwNOA==@protonmail.internalid>
	<2102171.1630517255@sss.pgh.pa.us>
	<3316564.aeNJFYEL58@aivenlaptop>

Ronan Dunklau <ronan.dunklau@aiven.io> writes:
> Le mercredi 1 septembre 2021, 19:27:35 heure normale d’Europe centrale Tom 
> Lane a écrit :
>> The rest of this is stuck pending investigation of the ideas about
>> making new-style function creation safer when the creation-time path
>> isn't secure, so I suppose we should mark it RWF rather than leaving
>> it in the queue.  Will go do that.

> Sorry to revive such an old thread but ... since the introduction of the 
> @extschema:name@ syntax in 72a5b1fc880481914da2d4233077438dd87840ca we can now 
> proceed with this or am I missing something ?

Yeah, seems like we could make it work with that.

> I've updated the previous patches to convert them to the new-style, added one 
> for lo as well.

The cfbot says many of these fail regression tests --- lots of

 CREATE EXTENSION citext SCHEMA s;
+ERROR:  extension "citext" has no installation script nor update path for version "1.8"

and such.  I didn't poke into why, but maybe you missed "git add'ing"
some changes?

			regards, tom lane





view thread (44+ messages)  latest in thread

Message-ID: <2650823.1730736601@sss.pgh.pa.us>
Permalink:  ../2650823.1730736601@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2650823.1730736601@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, ronan.dunklau@aiven.io, peter.eisentraut@enterprisedb.com
  Subject: Re: Converting contrib SQL functions to new style
  In-Reply-To: <2650823.1730736601@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox