pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nikolay Shaplov <dhyan@nataraj.su>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Subject: BRIN autosummarize tests
Date: Wed, 19 Apr 2017 19:53:57 +0300
Message-ID: <2700647.XEouBYNZic@x200m> (raw)
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>


Hi!

Alvaro, you've recently commited patch with BRIN autosummarize

Tell me, this feature can't be really tested via regression tests?

Because now I am rebasing my reloptions patch (again!), and as it was partly 
rebased, I run make check. 
At that point I did not moved implementation of this option completely, and 
thus autosummarize were forever set to false.

And in this obviously broken situation all tests were successful when I run 
them. May be there can be a way to make sure it is really works, and one 
should add it to the tests?



-- 
Nikolay Shaplov, independent Perl & C/C++ developer. Available for hire.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



Message-ID: <2700647.XEouBYNZic@x200m>
Permalink:  ../2700647.XEouBYNZic@x200m/
Also on:    postgresql.org/message-id/2700647.XEouBYNZic@x200m

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: dhyan@nataraj.su, alvherre@2ndquadrant.com
  Subject: Re: BRIN autosummarize tests
  In-Reply-To: <2700647.XEouBYNZic@x200m>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox