From: Tom Lane <tgl@sss.pgh.pa.us>
To: jean.pierre.pelletier0 <jean.pierre.pelletier0@gmail.com>
Cc: pgsql-hackers@postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: psql \dC incorrectly shows casts "with inout" as "binary coercible" on 9.5.14 and 11beta3
Date: Fri, 31 Aug 2018 10:33:10 -0400
Message-ID: <27178.1535725990@sss.pgh.pa.us> (raw)
In-Reply-To: <5b887023.1c69fb81.ff96e.6a1d@mx.google.com>
References: <5b887023.1c69fb81.ff96e.6a1d@mx.google.com>
"jean.pierre.pelletier0" <jean.pierre.pelletier0@gmail.com> writes:
> To reproduce, compare the output of \dC on two built-in casts(json to jsonb) and (xml to text) where only the the first is really "with inout".
Hm, yeah, it just does
" CASE WHEN castfunc = 0 THEN '(binary coercible)'\n"
" ELSE p.proname\n"
" END as \"%s\",\n"
without regard for the castmethod column (which it can't necessarily
assume is there, anyway). It's hard to be sure after all these
years whether this was intentional or just an oversight, unless maybe
Heikki remembers ... but I tend to agree that "(with inout)" would be
more apropos than "(binary coercible)".
Not sure if this rises to the level of a back-patchable bug.
People might be surprised if we change that output in minor releases.
But we could still squeeze it into v11, I think.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, jean.pierre.pelletier0@gmail.com, hlinnaka@iki.fi
Subject: Re: psql \dC incorrectly shows casts "with inout" as "binary coercible" on 9.5.14 and 11beta3
In-Reply-To: <27178.1535725990@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox