pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Arthur Zakirov <a.zakirov@postgrespro.ru>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
Date: Sun, 25 Mar 2018 00:56:38 -0400
Message-ID: <27184.1521953798@sss.pgh.pa.us> (raw)
In-Reply-To: <eb7dca33-db16-46d9-95a0-a621c2d85918@2ndquadrant.com>
References: <CAFj8pRDm9nhZCf16XDer-eeciqy0wipR0Y4+ZdwGMAWuv-k6ag@mail.gmail.com>
	<20180307131819.GA13301@zakirov.localdomain>
	<3c7910ba-2a1b-5b73-71c6-d037ba1e89bd@2ndquadrant.com>
	<CAKNkYnzWuSV-JoMBPDrWPjomUC4n1QtYd8Yugo9hpJrbtHcALg@mail.gmail.com>
	<d4d52484-e269-9d7b-cef5-c1e95a03d9c6@2ndquadrant.com>
	<20180319110648.GA32319@zakirov.localdomain>
	<2ae9588a-f3cb-777d-1958-c76c22225823@2ndquadrant.com>
	<20180320131149.GA12884@zakirov.localdomain>
	<ebcb7f9d-eec2-3138-efde-af83b6a0f04f@2ndquadrant.com>
	<20180321090050.GA21751@zakirov.localdomain>
	<20180322105603.GA23544@zakirov.localdomain>
	<28250.1521924996@sss.pgh.pa.us>
	<ada73d07-6c88-acab-7e31-75b2eb724d24@2ndquadrant.com>
	<25186.1521951490@sss.pgh.pa.us>
	<eb7dca33-db16-46d9-95a0-a621c2d85918@2ndquadrant.com>

Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> FWIW this is where the view listing dictionaries loaded into shared
> memory would be helpful - you'd at least know there's a dictionary,
> wasting memory.

Well, that's only because we failed to make the implementation transparent
:-(.  But it's not unlikely that an mmap-based implementation would be
simply incapable of supporting such a view: the knowledge of whether a
particular file is mapped in would be pretty much process-local, I think.
So I'd really rather we don't add that.

Also, while these dictionaries are indeed kind of large relative to our
traditional view of shared memory, if they're in DSM segments that the
kernel can swap out then I really suspect that nobody would much care
if a few such segments had been leaked.  I find it hard to imagine a
use-case where DROP race conditions would lead us to leak so many that
it becomes a serious problem.  Maybe I lack imagination.

			regards, tom lane




view thread (108+ messages)  latest in thread

Message-ID: <27184.1521953798@sss.pgh.pa.us>
Permalink:  ../27184.1521953798@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/27184.1521953798@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, a.zakirov@postgrespro.ru, pavel.stehule@gmail.com, andres@anarazel.de, i.kurbangaliev@postgrespro.ru
  Subject: Re: [PROPOSAL] Shared Ispell dictionaries
  In-Reply-To: <27184.1521953798@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox