From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Failure in commit_ts tap tests
Date: Sat, 21 Jan 2017 11:09:14 -0500
Message-ID: <27447.1485014954@sss.pgh.pa.us> (raw)
In-Reply-To: <CABOikdPatXWB1y_-WvOA5Y1CbcT_SHstSQJoYDgK9+WXWK0TYw@mail.gmail.com>
References: <20170120182702.tjjk2mh3t5keansh@alvherre.pgsql>
<21212.1484939708@sss.pgh.pa.us>
<CABOikdMLJnn4ZvrP055TjuqH=+d+muCfY6i-O8+_34FPQutrAQ@mail.gmail.com>
<26339.1485013196@sss.pgh.pa.us>
<CABOikdPatXWB1y_-WvOA5Y1CbcT_SHstSQJoYDgK9+WXWK0TYw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Pavan Deolasee <pavan.deolasee@gmail.com> writes:
> On Sat, Jan 21, 2017 at 9:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hm, but what of the "null" value? Also, I get
>>
>> $ perl -e 'use warnings; use Test::More; ok("2017-01-01" != "null", "ok");'
>> Argument "null" isn't numeric in numeric ne (!=) at -e line 1.
>> Argument "2017-01-01" isn't numeric in numeric ne (!=) at -e line 1.
>> ok 1 - ok
> It declares the test as "passed", right?
Oh! So it does. That is one darn weird behavior of the != operator.
> I am not saying that's a correct
> behaviour, but that's why we didn't catch the problem earlier.
Check. Mystery solved.
There's still the point that we're not actually exercising this script
in the buildfarm ...
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pavan.deolasee@gmail.com, alvherre@2ndquadrant.com
Subject: Re: Failure in commit_ts tap tests
In-Reply-To: <27447.1485014954@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox