pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Daniil Zakhlystov <usernamedt@yandex-team.ru>
To: Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: o.bartunov@postgrespro.ru <o.bartunov@postgrespro.ru>
Subject: Re: libpq compression
Date: Mon, 02 Nov 2020 21:32:30 +0500
Message-ID: <2751271604329658@mail.yandex-team.ru> (raw)
References: <c0230242-2279-d6f7-e1ff-d3de908bdfbc@postgrespro.ru>
	<a5eaca1d-a226-f993-a265-8e5d8ba9bf6e@pgmasters.net>
	<c5421f2e-918a-2e74-f91a-a951d49012c4@postgrespro.ru>
	<a112e0a2-6908-5a0d-ac22-012ebb6169b0@postgrespro.ru>
	<74F0A385-6ED4-4EA7-9498-1A8527F16472@yandex-team.ru>
	<a13ce4d1-768c-1449-25f6-0cd645499d93@postgrespro.ru>
	<fa9113c0-db7a-2ed8-111c-a082a2217e4b@postgrespro.ru>
	<22446ba0-058d-624a-a679-edc0215a56c8@postgrespro.ru>
	<20201028192712.xj2qneyb3fvmjm6c@alap3.anarazel.de>
	<3b1d2752-b7b5-db39-84c9-4ff024041fff@postgrespro.ru>
	<20201030210308.54jjmnvhspk6p7cb@alap3.anarazel.de>
	<0ae2162b-818f-6a6d-cca6-ee4e73733e8e@postgrespro.ru>
	<67498D86-006D-4D56-85E2-88ABA07B2715@yandex-team.ru>
	<34328cc0-9669-f30d-50f6-46e9f3f21cde@postgrespro.ru>
	<ED4564BD-0DA3-4630-8AA3-9051D29717F7@yandex-team.ru>
	<9d33e21e-54b2-fcf3-b90f-ced286df00c5@postgrespro.ru>

<div><div>Hi,</div><div> </div><div>Currently, zpq_stream contains a check only for the tx buffered data - zpq_buffered().</div><div> </div><div>I think that there should be the same functionality for rx buffered data. For example, the zpq_buffered_rx().</div><div> </div><div>zpq_buffered_rx() returns a value greater than zero if there is any data that was fetched by rx_func() but haven't been decompressed yet, in any other case zpq_buffered_rx() returns zero.</div><div> </div><div>In this case, I think that we may also rename the existing zpq_buffered() to zpq_buffered_tx() for clarity.<br /><br />--<br />Daniil Zakhlystov</div></div>





view thread (289+ messages)  latest in thread

Message-ID: <2751271604329658@mail.yandex-team.ru>
Permalink:  ../2751271604329658@mail.yandex-team.ru/
Also on:    postgresql.org/message-id/2751271604329658@mail.yandex-team.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: usernamedt@yandex-team.ru, k.knizhnik@postgrespro.ru, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, x4mmm@yandex-team.ru, o.bartunov@postgrespro.ru
  Subject: Re: libpq compression
  In-Reply-To: <2751271604329658@mail.yandex-team.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox