pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
To: David Steele <david@pgmasters.net>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Robbie Harwood <rharwood@redhat.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Grigory Smolkin <g.smolkin@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq compression
Date: Mon, 25 Mar 2019 12:04:05 +0300
Message-ID: <c0230242-2279-d6f7-e1ff-d3de908bdfbc@postgrespro.ru> (raw)
In-Reply-To: <2bc25ca4-2d60-a635-b0bc-5f7fd12ea4eb@pgmasters.net>
References: <aad16e41-b3f9-e89d-fa57-fb4c694bec25@postgrespro.ru>
	<dbf9035f-7f7b-b053-cc2a-52e5147d4557@postgrespro.ru>
	<429cf55b-a8bf-c4ba-196d-5b45420145a1@postgrespro.ru>
	<CAEepm=3CGUX4Vyw=jFaOedt99HS1HQiBKYTX4OYHo7HU2AczZg@mail.gmail.com>
	<36db5d02-45e6-b863-1418-825ef20ae4c6@postgrespro.ru>
	<CAEepm=3RAS8xVQK8rs+Xitzp+JXzGdGsMA7f+H8fjKQ7Do8aSA@mail.gmail.com>
	<f4ad0809-dd90-e321-5c1a-0ca68a136a8f@postgrespro.ru>
	<jlg4lhzdeak.fsf@redhat.com>
	<3b0260da-fe47-2341-da01-51383fe9172d@postgrespro.ru>
	<ebc8ebd2-1a3b-43f7-d1a1-6e8b9ed65e62@2ndquadrant.com>
	<cd974e7e-85da-19a4-f25b-a7a56ff87d00@postgrespro.ru>
	<739641a6-f64d-0f2b-8483-34ab23e2dcd6@2ndquadrant.com>
	<d58ebe47-5662-a50f-117d-4c1049acbfef@postgrespro.ru>
	<2bc25ca4-2d60-a635-b0bc-5f7fd12ea4eb@pgmasters.net>



On 25.03.2019 11:06, David Steele wrote:
> Konstantin,
>
>
> This patch appears to be failing tests so I have marked it Waiting on 
> Author.
>
> I have also removed the reviewer since no review had been done. Maybe 
> somebody else will have a look.
>
> Regards,

Can you please inform me which tests are failed?
I have done "make check-world" and there were no failed tests.
Actually if compression is not enabled (and it is disabled by default 
unless explicitly requested by client), there should be no difference 
with vanilla Postgres.
So it will be strange if some tests are failed without using compression.


-- 
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company





view thread (289+ messages)  latest in thread

Message-ID: <c0230242-2279-d6f7-e1ff-d3de908bdfbc@postgrespro.ru>
Permalink:  ../c0230242-2279-d6f7-e1ff-d3de908bdfbc@postgrespro.ru/
Also on:    postgresql.org/message-id/c0230242-2279-d6f7-e1ff-d3de908bdfbc@postgrespro.ru

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: k.knizhnik@postgrespro.ru, david@pgmasters.net, tomas.vondra@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, rharwood@redhat.com, thomas.munro@enterprisedb.com, g.smolkin@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: libpq compression
  In-Reply-To: <c0230242-2279-d6f7-e1ff-d3de908bdfbc@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox